Skip to content

build: Fix reference to Sentry.SourceGenerators #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
+17 −4
Draft

build: Fix reference to Sentry.SourceGenerators #4307

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d0e0f8f
build: fix source gen ref
Flash0ver Jun 25, 2025
810763b
build: add Error when no analyzer assemblies are found
Flash0ver Jun 26, 2025
36160c7
build: add Messages to _SentryPackAnalyzers Target
Flash0ver Jun 27, 2025
47a4fa3
Merge branch 'main' into build/fix-source-gen-ref
Flash0ver Jun 30, 2025
42ca3d1
build: replace ProjectReference with MSBuild
Flash0ver Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/Sentry/Sentry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,10 +202,23 @@
<None Include="buildTransitive\Sentry.SourceGenerators.targets" Pack="true" PackagePath="build\Sentry.SourceGenerators.targets" />
</ItemGroup>

<!-- Build and Pack (without dependency to) Roslyn Components / Compiler Extensions (as "analyzers"). -->
<!-- See https://learn.microsoft.com/dotnet/core/project-sdk/overview -->
<!-- See also https://github.com/ViktorHofer/PackAsAnalyzer -->
<ItemGroup>
<None Include="..\Sentry.SourceGenerators\bin\Release\netstandard2.0\Sentry.SourceGenerators.dll"
Pack="true"
PackagePath="analyzers/dotnet/cs"
Visible="false" />
<SentryAnalyzerProjectReference Include="..\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've got this in various other places throughout the solution. I'm wondering if it should be in one or more of the Directory.Build.props files (e.g. the one in the Samples directory, at the very least).

sentry-dotnet/test/Sentry.SourceGenerators.Tests/Sentry.SourceGenerators.Tests.csproj

Line 17 in 0514bfe

<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"/>

sentry-dotnet/samples/Sentry.Samples.Android/Sentry.Samples.Android.csproj

Lines 15 to 17 in 0514bfe

<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>

sentry-dotnet/samples/Sentry.Samples.Ios/Sentry.Samples.Ios.csproj

Lines 47 to 49 in 0514bfe

<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>

sentry-dotnet/samples/Sentry.Samples.MacCatalyst/Sentry.Samples.MacCatalyst.csproj

Lines 47 to 49 in 0514bfe

<ProjectReference Include="..\..\src\Sentry.SourceGenerators\Sentry.SourceGenerators.csproj"
OutputItemType="Analyzer"
ReferenceOutputAssembly="false"/>

</ItemGroup>
<Target Name="_SentryPackAnalyzers" BeforeTargets="GenerateNuspec;_GetPackageFiles">
<Message Text="Target: '_SentryPackAnalyzers' with Analyzer-Projects: '@(SentryAnalyzerProjectReference)'" Importance="high" />
<MSBuild Projects="@(SentryAnalyzerProjectReference)" Properties="Configuration=$(Configuration);TargetFramework=netstandard2.0"/>
<MSBuild Projects="@(SentryAnalyzerProjectReference)" Properties="Configuration=$(Configuration);TargetFramework=netstandard2.0" Targets="GetTargetPath">
<Output TaskParameter="TargetOutputs" ItemName="_SentryAnalyzersPackagePath" />
</MSBuild>
<Error Text="No analyzer assemblies found to pack." Condition="'@(_SentryAnalyzersPackagePath)' == ''" />
<Message Text="Packing Analyzers: '@(_SentryAnalyzersPackagePath)'" Importance="high" />
<ItemGroup>
<None Include="@(_SentryAnalyzersPackagePath)" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" />
</ItemGroup>
</Target>

</Project>
Loading