-
-
Notifications
You must be signed in to change notification settings - Fork 221
fix: Source context for class libraries when running on Android in Release mode #4294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
d97b4cb
fix: Source context for class libraries when running on Android in Re…
jamescrosswell 99ecda7
Update CHANGELOG.md
jamescrosswell eaf4382
Merge branch 'main' into multi-project-maui
jamescrosswell 77a3836
Merge branch 'main' into multi-project-maui
jamescrosswell 0fae5db
Update CHANGELOG.md
jamescrosswell d6366f6
Merge branch 'main' into multi-project-maui
jamescrosswell 68674b6
Merge branch 'main' into multi-project-maui
jamescrosswell be7ea6e
Update AndroidAssemblyStoreReaderV2.cs
jamescrosswell 057489f
Update AndroidAssemblyStoreReaderV2.cs
jamescrosswell 19f22ec
Update CachingTransportTests.cs
jamescrosswell 50ab8f4
Merge branch 'main' into multi-project-maui
jamescrosswell e322bef
Merge branch 'main' into multi-project-maui
jamescrosswell 544b354
Update Sentry.Maui.Device.TestApp.csproj
jamescrosswell 6dd5218
Update device-tests-android.yml
jamescrosswell ce0a859
Exclude SentryMauiOptionsTests (testing)
jamescrosswell 76ae028
Merge branch 'main' into multi-project-maui
jamescrosswell a33c654
Update CHANGELOG.md
jamescrosswell 2b15fda
Try FakeReliableNetworkStatusListener in SentryMauiOptionsTests
jamescrosswell 982ffe4
Disable all but one SentryMauiOptionsTests
jamescrosswell d68676c
Update SentryMauiOptionsTests.cs
jamescrosswell 3a36d99
Merge branch 'main' into multi-project-maui
jamescrosswell 849d704
Try skipping event binders
jamescrosswell 7bd5069
Update CachingTransportTests.cs
jamescrosswell a527401
Try removing callbacks
jamescrosswell 882e6cc
Merge branch 'main' into multi-project-maui
jamescrosswell 2d2e1b2
Moved default event binders into SentryMauiAppBuilderExtensions
jamescrosswell c58d2d9
Uncomment the other device tests again
jamescrosswell 6686e9e
Renamed InjectedEventBinders to IntegrationEventBinders
jamescrosswell 11f09e4
Update SentryMauiAppBuilderExtensions.cs
jamescrosswell 8689ce3
Try commenting out MauiCommunityToolkitMvvmEventsBinderTests
jamescrosswell bc87f3e
Update Startup.cs
jamescrosswell 88daf10
Back to just the SentrySdkTests
jamescrosswell eed38d9
Added LogLevelExtensionsTests & AndroidAssemblyReaderTests
jamescrosswell 053831f
Added SentryMauiOptionsTests back again
jamescrosswell ba8e335
No SentryMauiOptionsTests but MauiCommunityToolkitMvvmEventsBinderTests
jamescrosswell b3fea09
Include half the Sentry.Maui.Tests
jamescrosswell 00ff1f2
Disable the other half
jamescrosswell ac86208
Just api and options tests
jamescrosswell e8375ab
Update Sentry.Maui.Tests.csproj
jamescrosswell 1a080dd
Include logcat and screenshot tests
jamescrosswell 2d954bc
Add SentryMauiAppBuilderExtensionsTests
jamescrosswell f0d9a3c
Added MauiNetworkStatusListenerTests and BreadcrumbEventTests
jamescrosswell 1dde8f7
Added back MauiEventsBinderTests
jamescrosswell acc5518
Reintroduce button binders
jamescrosswell 614b33e
Reintroduce MauiGestureRecognizerEventsBinderTests
jamescrosswell da061fc
Reintroduce MauiVisualElementEventsBinderTests
jamescrosswell 527e09e
Reintroduce SentryMauiLogcatsTests
jamescrosswell ce94206
Reintroduce CaptureException_RemoveScreenshot_NotContainsScreenshotAt…
jamescrosswell 9346258
Reintroduce CaptureException_BeforeCaptureScreenshot_DisableCaptureAsync
jamescrosswell cb19808
Update MauiImageButtonEventsBinder.cs
jamescrosswell 4e12078
Reintroduce/tweak CaptureException_AttachScreenshot_Threadsafe
jamescrosswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like we have one logger but shouldn't this be a level Error log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd have to refactor the AssemblyReader classes that we vendored in fomr MS in order to be able to do that (they use a different pattern for logging).
Probably the easiest would be to replace DebugLogger with our own
IDiagnosticLogger
... would involve quite a few changes, but then we've made so many changes to these already that the only way to merge in changes from new code is by hand. So a few more changes wouldn't hurt.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bruno-garcia one remaining question on this PR is whether we want to refactor all the vendored in code to use our
IDiagnosticLogger
instead of theDebugLogger
delegate that is used currently:sentry-dotnet/src/Sentry.Android.AssemblyReader/DebugLogger.cs
Line 8 in 4ee96ee
The existing delegate doesn't have any notion of "log levels" (so doesn't support what you suggested above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add that as a requirement to unblock this. But it's not unreasonable to add if it'll help us debug this better going forward
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k, I'll track that in a separate issue as I think we should get this fix out ASAP:
IDiagnosticLogger
#4382