Skip to content

chore(python): Rename start_span parameter #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sentrivana
Copy link
Contributor

We'll be changing the name of this parameter, updating.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Jul 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 9:08am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Jul 24, 2025 9:08am

@sentrivana sentrivana changed the title chore(python): Rename parameter chore(python): Rename start_span parameter Jul 24, 2025
@sentrivana sentrivana marked this pull request as ready for review July 24, 2025 08:52
Copy link

codecov bot commented Jul 24, 2025

Bundle Report

Changes will increase total bundle size by 651 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.84MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.24MB 657 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 880.61kB -0.0%
static/chunks/1831-*.js -3 bytes 423.03kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/s6CH76XVZSEFOemkCz2w7/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/s6CH76XVZSEFOemkCz2w7/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/_qXl8wlC_RhlyrBGV0HR4/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/_qXl8wlC_RhlyrBGV0HR4/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 222 bytes 724.81kB 0.03%
../app/platform-redirect/page.js.nft.json 222 bytes 724.72kB 0.03%
../app/sitemap.xml/route.js.nft.json 222 bytes 722.2kB 0.03%

@sentrivana
Copy link
Contributor Author

Will merge as soon as we release the change (in the next alpha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants