-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Nextjs source map doc updates #14433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 1.74kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great update, small nits but non-blocking
Co-authored-by: Sergiy Dybskiy <sergiy.dybskiy@sentry.io>
Co-authored-by: Sergiy Dybskiy <sergiy.dybskiy@sentry.io>
project: "___PROJECT_SLUG___", | ||
authToken: process.env.SENTRY_AUTH_TOKEN, | ||
sourcemaps: { | ||
disable: false, // Enable source maps (default: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disable: false, // Enable source maps (default: false) | |
disable: false, // Disable source maps (default: false) |
disable: false, // Enable source maps (default: false) | ||
assets: ["**/*.js", "**/*.js.map"], // Specify which files to upload | ||
ignore: ["**/node_modules/**"], // Files to exclude | ||
deleteSourcemapsAfterUpload: true, // Security: delete after upload |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention that this is true by default
); | ||
``` | ||
|
||
#### 2. Source Map Options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention somewhere here that everything below is optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
DESCRIBE YOUR PR
Updating the source map includes for nexjs to bring back the explainer on why source maps are so important, and give a little bit of detail around configuring.
Removing the nodejs blog post link from the javascript sourcemap doc. It's outdated, and it's irrelevant to the other frameworks. We can always add it into the node.js includes if we want it back, though it should be updated if we want it back.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: