Skip to content

Nextjs source map doc updates #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 24, 2025
Merged

Nextjs source map doc updates #14433

merged 8 commits into from
Jul 24, 2025

Conversation

sfanahata
Copy link
Contributor

@sfanahata sfanahata commented Jul 23, 2025

DESCRIBE YOUR PR

Updating the source map includes for nexjs to bring back the explainer on why source maps are so important, and give a little bit of detail around configuring.

Removing the nodejs blog post link from the javascript sourcemap doc. It's outdated, and it's irrelevant to the other frameworks. We can always add it into the node.js includes if we want it back, though it should be updated if we want it back.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2025 5:04pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2025 5:04pm

Copy link

codecov bot commented Jul 23, 2025

Bundle Report

Changes will increase total bundle size by 1.74kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.84MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 12.24MB 1.75kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.75MB -0.0%
../instrumentation.js -3 bytes 1.08MB -0.0%
9523.js -3 bytes 1.05MB -0.0%
../app/[[...path]]/page.js.nft.json 585 bytes 724.98kB 0.08%
../app/platform-redirect/page.js.nft.json 585 bytes 724.89kB 0.08%
../app/sitemap.xml/route.js.nft.json 585 bytes 722.37kB 0.08%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 880.61kB -0.0%
static/chunks/1831-*.js -3 bytes 423.03kB -0.0%
static/mCZZ_mziULUbJ17_PjEAi/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/mCZZ_mziULUbJ17_PjEAi/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/dVRYvZ1CeFzsELnR4HGyX/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/dVRYvZ1CeFzsELnR4HGyX/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Contributor

@sergical sergical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great update, small nits but non-blocking

sfanahata and others added 2 commits July 23, 2025 11:40
Co-authored-by: Sergiy Dybskiy <sergiy.dybskiy@sentry.io>
Co-authored-by: Sergiy Dybskiy <sergiy.dybskiy@sentry.io>
project: "___PROJECT_SLUG___",
authToken: process.env.SENTRY_AUTH_TOKEN,
sourcemaps: {
disable: false, // Enable source maps (default: false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
disable: false, // Enable source maps (default: false)
disable: false, // Disable source maps (default: false)

disable: false, // Enable source maps (default: false)
assets: ["**/*.js", "**/*.js.map"], // Specify which files to upload
ignore: ["**/node_modules/**"], // Files to exclude
deleteSourcemapsAfterUpload: true, // Security: delete after upload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention that this is true by default

);
```

#### 2. Source Map Options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention somewhere here that everything below is optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@sfanahata sfanahata merged commit bff9631 into master Jul 24, 2025
13 checks passed
@sfanahata sfanahata deleted the nextjs-source-map-updates branch July 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants