-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Godot: Add page for Android support #14270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 2.64kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's odd to have this page be top level while desktop isn't. when we add iOS and Web would those also get dedicated pages? we don't do this on other game engine sdks usually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So where should we place it if not top-level? Don't think we want to clutter the landing page.
UPDATE:
Perhaps, this belongs in configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to configuration section, removed features, and streamlined the rest.
|
||
Setting up Sentry for Android exports requires using Godot's Gradle build system. The Sentry SDK automatically integrates with your Gradle project, but you need to set up the Android build template first. | ||
|
||
### Prerequisites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like On-boarding instructions. But it involves general Godot Android on-boarding; right? so if the dev already has the game running on Android, are all these step needed?
We have on-boarding stuff on the landing page. ideally this goes there. maybe with the tab control to pick platform target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users MUST set up Gradle build system. Normally, this is not required. You can export Godot projects to Android without involving Gradle build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if the dev already has the game running on Android, are all these step needed?
Not all of these steps are needed, but some are absolutely required. I think it's better to be explicit, in case users are coming fresh without any export set up initially. But let me know if you think we shouldn't go extra mile here.
681f69c
to
fa9c2b0
Compare
DESCRIBE YOUR PR
Add a page with instructions for Android exports in the Godot SDK. Android support is added starting with
1.0-alpha.1
.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES