Skip to content

Clarify behaviour for AggregateExceptions in the SetBeforeSend hook #14265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jamescrosswell
Copy link
Collaborator

DESCRIBE YOUR PR

Resolves getsentry/sentry-dotnet#3751

IS YOUR CHANGE URGENT?

  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.

cc: @Flash0ver

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jul 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 9:48pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 8, 2025 9:48pm

@jamescrosswell jamescrosswell requested a review from Flash0ver July 7, 2025 03:44
@codeowner-assignment codeowner-assignment bot requested a review from a team July 7, 2025 03:44
Copy link

codecov bot commented Jul 7, 2025

Bundle Report

Changes will increase total bundle size by 375 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 11.79MB 381 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.8MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 873.24kB -0.0%
static/chunks/7750-*.js -3 bytes 415.85kB -0.0%
static/15xQMsyksg91y5S3cKaGp/_buildManifest.js (New) 684 bytes 684 bytes 100.0% 🚀
static/15xQMsyksg91y5S3cKaGp/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/fW1N4KrKF_eX5xpmgugVp/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/fW1N4KrKF_eX5xpmgugVp/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.64MB -0.0%
../instrumentation.js -3 bytes 973.36kB -0.0%
9523.js -3 bytes 949.31kB -0.0%
../app/[[...path]]/page.js.nft.json 130 bytes 690.02kB 0.02%
../app/platform-redirect/page.js.nft.json 130 bytes 689.94kB 0.02%
../app/sitemap.xml/route.js.nft.json 130 bytes 687.91kB 0.02%

Co-authored-by: Stefan Pölz <38893694+Flash0ver@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering exceptions in BeforeSend is not obvious for AggregateExceptions
2 participants