-
-
Notifications
You must be signed in to change notification settings - Fork 266
fix(jni): update proguard rules #3036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
==========================================
+ Coverage 87.97% 89.79% +1.81%
==========================================
Files 287 96 -191
Lines 9533 3331 -6202
==========================================
- Hits 8387 2991 -5396
+ Misses 1146 340 -806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Android Performance metrics 🚀
|
iOS Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can verify that this does the correct thing? Integration test with Android release build on CI maybe?
@denrase I tested it locally and the user confirmed it works in the issue |
we can in the future set up better integration tests with maestro |
-keep class io.sentry.flutter.** { *; } | ||
|
||
# Keep replay integration classes used by JNI | ||
-keep class io.sentry.android.replay.** { *; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is merged but maybe worth following up with a change to keep all io.sentry.* classes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah sounds good 👍
📜 Description
💡 Motivation and Context
Running the app in release means the native java symbols names are obfuscated so we need to add additional rules for keeping them in their original names for JNI to work properly
Closes #3030
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps