-
-
Notifications
You must be signed in to change notification settings - Fork 266
Report Flutter framework feature flags #2991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
===========================================
- Coverage 87.97% 63.09% -24.89%
===========================================
Files 287 4 -283
Lines 9533 168 -9365
===========================================
- Hits 8387 106 -8281
+ Misses 1146 62 -1084 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
flutter/lib/src/integrations/flutter_framework_feature_flag_integration.dart
Outdated
Show resolved
Hide resolved
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
flutter/test/integrations/flutter_framework_feature_flag_integration_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
flutter/lib/src/integrations/flutter_framework_feature_flag_integration.dart
Outdated
Show resolved
Hide resolved
flutter/lib/src/integrations/flutter_framework_feature_flag_integration.dart
Outdated
Show resolved
Hide resolved
I would still wait with merging this PR until the linked PR is merged |
// if it's not in there. | ||
// As a result, we also don't know the whole list of flags, but only the active ones. | ||
// | ||
// See https://github.com/flutter/flutter/pull/168437 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I'm sure you're aware but this reaches into Flutter internals that aren't meant to be public. This isn't covered by Flutter's breaking change policy. I'd assume the format of FLUTTER_ENABLED_FEATURE_FLAGS
can and will change, even in a patch release. The current changes seem reasonable, but I'd consider documenting this so that future contributors are aware as well.
📜 Description
There's a Flutter framework PR (
flutter/flutter#168437, flutter/flutter#171545 (reland of the first PR)) that adds feature flags to Flutter itself.This PR supports that
💡 Motivation and Context
I want know whether a specific build used one of the feature flags.
💚 How did you test it?
Automated tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps
I'll keep this a draft until the linked PR is merged for some time. Afterwards this PR can be landed.