Skip to content

Report Flutter framework feature flags #2991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Jun 14, 2025

📜 Description

There's a Flutter framework PR (flutter/flutter#168437, flutter/flutter#171545 (reland of the first PR)) that adds feature flags to Flutter itself.
This PR supports that

💡 Motivation and Context

I want know whether a specific build used one of the feature flags.

💚 How did you test it?

Automated tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

I'll keep this a draft until the linked PR is merged for some time. Afterwards this PR can be landed.

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.09%. Comparing base (2d34233) to head (8e94480).

❗ There is a different number of reports uploaded between BASE (2d34233) and HEAD (8e94480). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (2d34233) HEAD (8e94480)
9 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2991       +/-   ##
===========================================
- Coverage   87.97%   63.09%   -24.89%     
===========================================
  Files         287        4      -283     
  Lines        9533      168     -9365     
===========================================
- Hits         8387      106     -8281     
+ Misses       1146       62     -1084     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ueman and others added 2 commits June 17, 2025 18:39
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
@ueman ueman marked this pull request as ready for review July 3, 2025 05:18
@ueman
Copy link
Collaborator Author

ueman commented Jul 3, 2025

I would still wait with merging this PR until the linked PR is merged

// if it's not in there.
// As a result, we also don't know the whole list of flags, but only the active ones.
//
// See https://github.com/flutter/flutter/pull/168437

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I'm sure you're aware but this reaches into Flutter internals that aren't meant to be public. This isn't covered by Flutter's breaking change policy. I'd assume the format of FLUTTER_ENABLED_FEATURE_FLAGS can and will change, even in a patch release. The current changes seem reasonable, but I'd consider documenting this so that future contributors are aware as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants