-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Remove v9 checks for debug image provider #6454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6454 +/- ##
=============================================
+ Coverage 86.795% 87.009% +0.213%
=============================================
Files 450 451 +1
Lines 37806 37751 -55
Branches 17493 17476 -17
=============================================
+ Hits 32814 32847 +33
+ Misses 4949 4859 -90
- Partials 43 45 +2
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
a67e933
to
910fb79
Compare
910fb79
to
ea8dff7
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
083e8c5 | 1227.74 ms | 1262.37 ms | 34.62 ms |
0309548 | 1225.04 ms | 1252.82 ms | 27.77 ms |
7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
3ffd0e5 | 1228.04 ms | 1253.04 ms | 25.00 ms |
d8ceea3 | 1234.15 ms | 1263.92 ms | 29.77 ms |
fac4ca3 | 1222.81 ms | 1235.83 ms | 13.02 ms |
6d40fee | 1217.47 ms | 1245.37 ms | 27.90 ms |
09471ff | 1239.98 ms | 1256.65 ms | 16.67 ms |
5cbd333 | 1219.93 ms | 1241.76 ms | 21.83 ms |
45482a6 | 1225.88 ms | 1254.27 ms | 28.39 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
083e8c5 | 23.75 KiB | 981.75 KiB | 958.00 KiB |
0309548 | 23.75 KiB | 994.74 KiB | 970.99 KiB |
7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
3ffd0e5 | 23.75 KiB | 947.55 KiB | 923.80 KiB |
d8ceea3 | 23.75 KiB | 980.81 KiB | 957.07 KiB |
fac4ca3 | 23.75 KiB | 902.01 KiB | 878.27 KiB |
6d40fee | 23.75 KiB | 912.37 KiB | 888.63 KiB |
09471ff | 23.75 KiB | 990.16 KiB | 966.41 KiB |
5cbd333 | 23.74 KiB | 969.77 KiB | 946.02 KiB |
45482a6 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
ea8dff7
to
cd501e4
Compare
The V9 migration makes this class internal instead of public, which means it needs to be migrated to Swift to be part of the Swift dependency container. This removes the V9 checks and migrates it to Swift
#skip-changelog
Closes #6455