Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 18, 2025

The V9 migration makes this class internal instead of public, which means it needs to be migrated to Swift to be part of the Swift dependency container. This removes the V9 checks and migrates it to Swift

#skip-changelog

Closes #6455

Copy link

codecov bot commented Oct 18, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.009%. Comparing base (1bf44b4) to head (cd501e4).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryDebugImageProviderInternal.m 80.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6454       +/-   ##
=============================================
+ Coverage   86.795%   87.009%   +0.213%     
=============================================
  Files          450       451        +1     
  Lines        37806     37751       -55     
  Branches     17493     17476       -17     
=============================================
+ Hits         32814     32847       +33     
+ Misses        4949      4859       -90     
- Partials        43        45        +2     
Files with missing lines Coverage Δ
SentryTestUtils/TestDebugImageProvider.swift 100.000% <ø> (+27.272%) ⬆️
Sources/Sentry/PrivateSentrySDKOnly.m 25.000% <ø> (+1.213%) ⬆️
...ces/Sentry/Profiling/SentryProfilerSerialization.m 86.219% <ø> (ø)
Sources/Sentry/SentryANRTrackingIntegration.m 97.041% <ø> (ø)
Sources/Sentry/SentryClient.m 99.327% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.254% <ø> (ø)
Sources/Sentry/SentryTracer.m 97.712% <ø> (+0.163%) ⬆️
...s/Swift/SentryCrash/SentryDebugImageProvider.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryDebugImageProviderInternal.m 81.176% <80.000%> (ø)

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf44b4...cd501e4. Read the comment docs.

@noahsmartin noahsmartin force-pushed the debugImageProviderV9 branch 4 times, most recently from a67e933 to 910fb79 Compare October 18, 2025 02:24
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 18, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.89 ms 1260.51 ms 34.62 ms
Size 23.75 KiB 1021.48 KiB 997.73 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
083e8c5 1227.74 ms 1262.37 ms 34.62 ms
0309548 1225.04 ms 1252.82 ms 27.77 ms
7d23639 1237.93 ms 1243.04 ms 5.11 ms
3ffd0e5 1228.04 ms 1253.04 ms 25.00 ms
d8ceea3 1234.15 ms 1263.92 ms 29.77 ms
fac4ca3 1222.81 ms 1235.83 ms 13.02 ms
6d40fee 1217.47 ms 1245.37 ms 27.90 ms
09471ff 1239.98 ms 1256.65 ms 16.67 ms
5cbd333 1219.93 ms 1241.76 ms 21.83 ms
45482a6 1225.88 ms 1254.27 ms 28.39 ms

App size

Revision Plain With Sentry Diff
083e8c5 23.75 KiB 981.75 KiB 958.00 KiB
0309548 23.75 KiB 994.74 KiB 970.99 KiB
7d23639 23.75 KiB 891.01 KiB 867.26 KiB
3ffd0e5 23.75 KiB 947.55 KiB 923.80 KiB
d8ceea3 23.75 KiB 980.81 KiB 957.07 KiB
fac4ca3 23.75 KiB 902.01 KiB 878.27 KiB
6d40fee 23.75 KiB 912.37 KiB 888.63 KiB
09471ff 23.75 KiB 990.16 KiB 966.41 KiB
5cbd333 23.74 KiB 969.77 KiB 946.02 KiB
45482a6 23.75 KiB 919.91 KiB 896.16 KiB

Previous results on branch: debugImageProviderV9

Startup times

Revision Plain With Sentry Diff
98bfcdb 1231.44 ms 1265.30 ms 33.86 ms

App size

Revision Plain With Sentry Diff
98bfcdb 23.75 KiB 1021.48 KiB 997.73 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Remove v9 checks for debug image provider

1 participant