-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Refactor app state manager to not use protocol #6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6452 +/- ##
==========================================
Coverage 86.970% 86.970%
==========================================
Files 449 450 +1
Lines 37637 37806 +169
Branches 17460 17496 +36
==========================================
+ Hits 32733 32880 +147
- Misses 4862 4883 +21
- Partials 42 43 +1
... and 19 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
b880a96
to
3212721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3212721
to
9d8a46f
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2be5991 | 1228.55 ms | 1264.65 ms | 36.10 ms |
aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
80538ca | 1216.70 ms | 1253.92 ms | 37.22 ms |
d1c0538 | 1227.49 ms | 1246.96 ms | 19.47 ms |
83d27f6 | 1233.56 ms | 1259.24 ms | 25.68 ms |
1339919 | 1214.82 ms | 1238.98 ms | 24.16 ms |
4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
daeeb27 | 1235.35 ms | 1253.77 ms | 18.42 ms |
bce9765 | 1229.42 ms | 1243.49 ms | 14.07 ms |
04435e6 | 1226.81 ms | 1252.56 ms | 25.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2be5991 | 23.75 KiB | 994.73 KiB | 970.98 KiB |
aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
80538ca | 23.75 KiB | 989.99 KiB | 966.24 KiB |
d1c0538 | 23.75 KiB | 928.87 KiB | 905.12 KiB |
83d27f6 | 23.75 KiB | 928.88 KiB | 905.13 KiB |
1339919 | 23.75 KiB | 919.70 KiB | 895.95 KiB |
4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
daeeb27 | 23.75 KiB | 989.12 KiB | 965.37 KiB |
bce9765 | 23.74 KiB | 874.06 KiB | 850.32 KiB |
04435e6 | 23.75 KiB | 1010.41 KiB | 986.66 KiB |
9d8a46f
to
adf8d68
Compare
adf8d68
to
15649e2
Compare
This also needs to use a class instead of a protocol to finish the swift conversion
#skip-changelog
Closes #6453