Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 17, 2025

This also needs to use a class instead of a protocol to finish the swift conversion

#skip-changelog

Closes #6453

Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 98.82353% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.970%. Comparing base (aa643c5) to head (15649e2).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryDependencyContainer.m 80.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              main     #6452    +/-   ##
==========================================
  Coverage   86.970%   86.970%            
==========================================
  Files          449       450     +1     
  Lines        37637     37806   +169     
  Branches     17460     17496    +36     
==========================================
+ Hits         32733     32880   +147     
- Misses        4862      4883    +21     
- Partials        42        43     +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryAppStartTracker.m 95.394% <ø> (ø)
Sources/Sentry/SentryAppStartTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryCrashIntegration.m 99.200% <100.000%> (ø)
Sources/Sentry/SentryDefaultAppStateManager.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryWatchdogTerminationLogic.m 83.050% <ø> (ø)
Sources/Sentry/SentryWatchdogTerminationTracker.m 100.000% <ø> (ø)
...try/SentryWatchdogTerminationTrackingIntegration.m 85.714% <100.000%> (ø)
Sources/Swift/SentryAppState.swift 97.115% <100.000%> (+0.056%) ⬆️
Sources/Swift/SentryAppStateManager.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.254% <80.000%> (ø)

... and 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa643c5...15649e2. Read the comment docs.

cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the appStateManagerRefactor branch from b880a96 to 3212721 Compare October 17, 2025 20:07
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the appStateManagerRefactor branch from 3212721 to 9d8a46f Compare October 17, 2025 20:10
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 17, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.92 ms 1252.46 ms 16.54 ms
Size 23.75 KiB 1021.19 KiB 997.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2be5991 1228.55 ms 1264.65 ms 36.10 ms
aa96485 1215.37 ms 1234.04 ms 18.67 ms
80538ca 1216.70 ms 1253.92 ms 37.22 ms
d1c0538 1227.49 ms 1246.96 ms 19.47 ms
83d27f6 1233.56 ms 1259.24 ms 25.68 ms
1339919 1214.82 ms 1238.98 ms 24.16 ms
4bf98bf 1219.13 ms 1244.50 ms 25.38 ms
daeeb27 1235.35 ms 1253.77 ms 18.42 ms
bce9765 1229.42 ms 1243.49 ms 14.07 ms
04435e6 1226.81 ms 1252.56 ms 25.75 ms

App size

Revision Plain With Sentry Diff
2be5991 23.75 KiB 994.73 KiB 970.98 KiB
aa96485 23.75 KiB 874.46 KiB 850.71 KiB
80538ca 23.75 KiB 989.99 KiB 966.24 KiB
d1c0538 23.75 KiB 928.87 KiB 905.12 KiB
83d27f6 23.75 KiB 928.88 KiB 905.13 KiB
1339919 23.75 KiB 919.70 KiB 895.95 KiB
4bf98bf 23.75 KiB 919.70 KiB 895.95 KiB
daeeb27 23.75 KiB 989.12 KiB 965.37 KiB
bce9765 23.74 KiB 874.06 KiB 850.32 KiB
04435e6 23.75 KiB 1010.41 KiB 986.66 KiB

Previous results on branch: appStateManagerRefactor

Startup times

Revision Plain With Sentry Diff
77ab3e4 1214.74 ms 1243.29 ms 28.55 ms

App size

Revision Plain With Sentry Diff
77ab3e4 23.75 KiB 1018.69 KiB 994.94 KiB

@noahsmartin noahsmartin force-pushed the appStateManagerRefactor branch from 9d8a46f to adf8d68 Compare October 17, 2025 22:09
@noahsmartin noahsmartin force-pushed the appStateManagerRefactor branch from adf8d68 to 15649e2 Compare October 17, 2025 22:22
@noahsmartin noahsmartin merged commit 1bf44b4 into main Oct 17, 2025
201 of 209 checks passed
@noahsmartin noahsmartin deleted the appStateManagerRefactor branch October 17, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Refactor app state manager to not use protocol

2 participants