-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Convert SentryCrash to swift #6438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d512093
to
3ff3356
Compare
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
3ff3356
to
f0176b0
Compare
b7c1127
to
f94a146
Compare
f94a146
to
12b9c98
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56d2052 | 1218.35 ms | 1247.58 ms | 29.23 ms |
3c86ff3 | 1227.82 ms | 1239.73 ms | 11.91 ms |
f8029e2 | 1245.16 ms | 1261.32 ms | 16.16 ms |
99104c9 | 1224.84 ms | 1247.08 ms | 22.24 ms |
0dd7283 | 1230.47 ms | 1255.94 ms | 25.47 ms |
570f725 | 1206.00 ms | 1238.96 ms | 32.96 ms |
7273bf4 | 1202.42 ms | 1227.62 ms | 25.21 ms |
aa96485 | 1215.37 ms | 1234.04 ms | 18.67 ms |
acac774 | 1217.76 ms | 1253.29 ms | 35.52 ms |
2be5991 | 1228.55 ms | 1264.65 ms | 36.10 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
56d2052 | 23.74 KiB | 976.80 KiB | 953.05 KiB |
3c86ff3 | 23.75 KiB | 919.69 KiB | 895.94 KiB |
f8029e2 | 23.75 KiB | 893.72 KiB | 869.97 KiB |
99104c9 | 23.75 KiB | 894.83 KiB | 871.09 KiB |
0dd7283 | 23.74 KiB | 997.28 KiB | 973.53 KiB |
570f725 | 23.74 KiB | 913.38 KiB | 889.63 KiB |
7273bf4 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
aa96485 | 23.75 KiB | 874.46 KiB | 850.71 KiB |
acac774 | 23.75 KiB | 866.51 KiB | 842.76 KiB |
2be5991 | 23.75 KiB | 994.73 KiB | 970.98 KiB |
3204ada
to
23216e3
Compare
itaybre
reviewed
Oct 16, 2025
itaybre
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
23216e3
to
3592a08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/COCOA-703/convert-sentrycrash-to-swift
#skip-changelog