Skip to content

Conversation

noahsmartin
Copy link
Contributor

Converts this protocol to Swift, closing https://linear.app/getsentry/issue/COCOA-716/convert-sentryscopeobserver-to-swift

#skip-changelog

Copy link

linear bot commented Oct 15, 2025

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.932%. Comparing base (466e905) to head (98b545e).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6431       +/-   ##
=============================================
- Coverage   86.943%   86.932%   -0.011%     
=============================================
  Files          447       447               
  Lines        37582     37582               
  Branches     17433     17436        +3     
=============================================
- Hits         32675     32671        -4     
  Misses        4865      4865               
- Partials        42        46        +4     
Files with missing lines Coverage Δ
Sources/Sentry/SentryCrashIntegration.m 99.200% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.376% <ø> (ø)
Sources/Sentry/SentryScope.m 97.065% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466e905...98b545e. Read the comment docs.

@noahsmartin noahsmartin force-pushed the convertSentryScopeObserverToSwift branch from cf52123 to 3d23e89 Compare October 15, 2025 15:42
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.95 ms 1260.64 ms 35.69 ms
Size 23.75 KiB 1010.42 KiB 986.67 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e3a42f 1222.90 ms 1245.67 ms 22.77 ms
1fe932f 1231.92 ms 1253.44 ms 21.52 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
2481950 1221.04 ms 1248.98 ms 27.94 ms
e4ba9a7 1219.82 ms 1230.89 ms 11.07 ms
ef2c9b3 1222.12 ms 1253.96 ms 31.84 ms
7d23639 1237.93 ms 1243.04 ms 5.11 ms
8bb3e37 1235.18 ms 1252.63 ms 17.45 ms
ae79d35 1227.15 ms 1252.55 ms 25.41 ms
7148f97 1235.09 ms 1258.07 ms 22.98 ms

App size

Revision Plain With Sentry Diff
8e3a42f 23.75 KiB 880.06 KiB 856.31 KiB
1fe932f 23.75 KiB 913.63 KiB 889.88 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
2481950 23.74 KiB 872.74 KiB 849.00 KiB
e4ba9a7 23.75 KiB 969.22 KiB 945.47 KiB
ef2c9b3 23.75 KiB 933.03 KiB 909.29 KiB
7d23639 23.75 KiB 891.01 KiB 867.26 KiB
8bb3e37 23.75 KiB 968.25 KiB 944.50 KiB
ae79d35 23.75 KiB 928.13 KiB 904.38 KiB
7148f97 23.75 KiB 854.78 KiB 831.03 KiB

Previous results on branch: convertSentryScopeObserverToSwift

Startup times

Revision Plain With Sentry Diff
8904f90 1232.10 ms 1261.27 ms 29.17 ms
fd7859f 1223.51 ms 1254.12 ms 30.61 ms

App size

Revision Plain With Sentry Diff
8904f90 23.75 KiB 1008.56 KiB 984.81 KiB
fd7859f 23.75 KiB 1006.39 KiB 982.64 KiB

@noahsmartin noahsmartin force-pushed the convertSentryScopeObserverToSwift branch from 3d23e89 to ae654fd Compare October 15, 2025 21:53
Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noahsmartin noahsmartin force-pushed the convertSentryScopeObserverToSwift branch from ae654fd to 98b545e Compare October 16, 2025 17:31
@noahsmartin noahsmartin merged commit 04435e6 into main Oct 16, 2025
188 of 193 checks passed
@noahsmartin noahsmartin deleted the convertSentryScopeObserverToSwift branch October 16, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants