-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Convert SentryScopeObserver to Swift #6431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6431 +/- ##
=============================================
- Coverage 86.943% 86.932% -0.011%
=============================================
Files 447 447
Lines 37582 37582
Branches 17433 17436 +3
=============================================
- Hits 32675 32671 -4
Misses 4865 4865
- Partials 42 46 +4
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cf52123
to
3d23e89
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8e3a42f | 1222.90 ms | 1245.67 ms | 22.77 ms |
1fe932f | 1231.92 ms | 1253.44 ms | 21.52 ms |
2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
2481950 | 1221.04 ms | 1248.98 ms | 27.94 ms |
e4ba9a7 | 1219.82 ms | 1230.89 ms | 11.07 ms |
ef2c9b3 | 1222.12 ms | 1253.96 ms | 31.84 ms |
7d23639 | 1237.93 ms | 1243.04 ms | 5.11 ms |
8bb3e37 | 1235.18 ms | 1252.63 ms | 17.45 ms |
ae79d35 | 1227.15 ms | 1252.55 ms | 25.41 ms |
7148f97 | 1235.09 ms | 1258.07 ms | 22.98 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8e3a42f | 23.75 KiB | 880.06 KiB | 856.31 KiB |
1fe932f | 23.75 KiB | 913.63 KiB | 889.88 KiB |
2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
2481950 | 23.74 KiB | 872.74 KiB | 849.00 KiB |
e4ba9a7 | 23.75 KiB | 969.22 KiB | 945.47 KiB |
ef2c9b3 | 23.75 KiB | 933.03 KiB | 909.29 KiB |
7d23639 | 23.75 KiB | 891.01 KiB | 867.26 KiB |
8bb3e37 | 23.75 KiB | 968.25 KiB | 944.50 KiB |
ae79d35 | 23.75 KiB | 928.13 KiB | 904.38 KiB |
7148f97 | 23.75 KiB | 854.78 KiB | 831.03 KiB |
Previous results on branch: convertSentryScopeObserverToSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8904f90 | 1232.10 ms | 1261.27 ms | 29.17 ms |
fd7859f | 1223.51 ms | 1254.12 ms | 30.61 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8904f90 | 23.75 KiB | 1008.56 KiB | 984.81 KiB |
fd7859f | 23.75 KiB | 1006.39 KiB | 982.64 KiB |
3d23e89
to
ae654fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ae654fd
to
98b545e
Compare
Converts this protocol to Swift, closing https://linear.app/getsentry/issue/COCOA-716/convert-sentryscopeobserver-to-swift
#skip-changelog