Skip to content

Conversation

noahsmartin
Copy link
Contributor

Copy link

linear bot commented Oct 15, 2025

Copy link

codecov bot commented Oct 15, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
4014 2 4012 28
View the top 3 failed test(s) by shortest run time
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:18 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testCaptureError
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:63 - Failed to terminate io.sentry.sample.iOS-Swift:7704: Failed to terminate io.sentry.sample.iOS-Swift:0
iOS_Swift_UITests.ProfilingUITests::testAppLaunchesWithContinuousProfilerV2ManualLifeCycle
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UITestHelpers.swift:5 - Failed to get matching snapshots: Timed out while evaluating UI query.
iOS_Swift_UITests.ViewLifecycleUITests::testViewLifecycle_callingDismissWithViewDidDisappear_shouldNotCrashSDK
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:63 - Failed to terminate io.sentry.sample.iOS-Swift:20766: Failed to terminate io.sentry.sample.iOS-Swift:0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

cursor[bot]

This comment was marked as outdated.

@noahsmartin noahsmartin force-pushed the sentrySwizzleWrapperSwift branch from 571b536 to bb1cd07 Compare October 15, 2025 14:44
Copy link
Contributor

github-actions bot commented Oct 15, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.59 ms 1269.47 ms 34.88 ms
Size 23.75 KiB 1008.67 KiB 984.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
43597ba 1214.88 ms 1243.52 ms 28.65 ms
5846fc5 1223.25 ms 1248.79 ms 25.54 ms
1bf432b 1200.22 ms 1226.90 ms 26.67 ms
d23a1b1 1218.94 ms 1239.53 ms 20.60 ms
e0a15a5 1230.53 ms 1266.35 ms 35.82 ms
ae7be93 1236.24 ms 1258.18 ms 21.94 ms
d05d866 1211.78 ms 1230.96 ms 19.18 ms
1a34ddc 1218.94 ms 1251.86 ms 32.92 ms
82f60cf 1218.65 ms 1238.52 ms 19.87 ms
7123d8e 1222.27 ms 1262.02 ms 39.76 ms

App size

Revision Plain With Sentry Diff
43597ba 23.75 KiB 880.32 KiB 856.58 KiB
5846fc5 23.75 KiB 912.77 KiB 889.02 KiB
1bf432b 23.75 KiB 926.64 KiB 902.90 KiB
d23a1b1 23.75 KiB 913.64 KiB 889.88 KiB
e0a15a5 23.75 KiB 979.10 KiB 955.35 KiB
ae7be93 23.75 KiB 879.24 KiB 855.49 KiB
d05d866 23.75 KiB 878.60 KiB 854.85 KiB
1a34ddc 23.75 KiB 919.88 KiB 896.13 KiB
82f60cf 23.75 KiB 913.63 KiB 889.88 KiB
7123d8e 23.75 KiB 986.80 KiB 963.05 KiB

Previous results on branch: sentrySwizzleWrapperSwift

Startup times

Revision Plain With Sentry Diff
6a8c688 1222.09 ms 1255.15 ms 33.06 ms
bff9404 1222.56 ms 1253.59 ms 31.04 ms

App size

Revision Plain With Sentry Diff
6a8c688 23.75 KiB 1008.52 KiB 984.77 KiB
bff9404 23.75 KiB 1008.59 KiB 984.84 KiB

Copy link
Contributor

@itaybre itaybre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a small question

@noahsmartin noahsmartin force-pushed the sentrySwizzleWrapperSwift branch 2 times, most recently from 15114ed to 6fdb51b Compare October 15, 2025 16:32
@noahsmartin noahsmartin force-pushed the sentrySwizzleWrapperSwift branch from 6fdb51b to 51a4fd9 Compare October 15, 2025 17:11
Copy link
Contributor

github-actions bot commented Oct 15, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentrySwizzleWrapper.m

@noahsmartin noahsmartin merged commit 535ebd9 into main Oct 15, 2025
174 of 180 checks passed
@noahsmartin noahsmartin deleted the sentrySwizzleWrapperSwift branch October 15, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants