-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: Convert SentrySwizzleWrapper to Swift #6429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
571b536
to
bb1cd07
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
43597ba | 1214.88 ms | 1243.52 ms | 28.65 ms |
5846fc5 | 1223.25 ms | 1248.79 ms | 25.54 ms |
1bf432b | 1200.22 ms | 1226.90 ms | 26.67 ms |
d23a1b1 | 1218.94 ms | 1239.53 ms | 20.60 ms |
e0a15a5 | 1230.53 ms | 1266.35 ms | 35.82 ms |
ae7be93 | 1236.24 ms | 1258.18 ms | 21.94 ms |
d05d866 | 1211.78 ms | 1230.96 ms | 19.18 ms |
1a34ddc | 1218.94 ms | 1251.86 ms | 32.92 ms |
82f60cf | 1218.65 ms | 1238.52 ms | 19.87 ms |
7123d8e | 1222.27 ms | 1262.02 ms | 39.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
43597ba | 23.75 KiB | 880.32 KiB | 856.58 KiB |
5846fc5 | 23.75 KiB | 912.77 KiB | 889.02 KiB |
1bf432b | 23.75 KiB | 926.64 KiB | 902.90 KiB |
d23a1b1 | 23.75 KiB | 913.64 KiB | 889.88 KiB |
e0a15a5 | 23.75 KiB | 979.10 KiB | 955.35 KiB |
ae7be93 | 23.75 KiB | 879.24 KiB | 855.49 KiB |
d05d866 | 23.75 KiB | 878.60 KiB | 854.85 KiB |
1a34ddc | 23.75 KiB | 919.88 KiB | 896.13 KiB |
82f60cf | 23.75 KiB | 913.63 KiB | 889.88 KiB |
7123d8e | 23.75 KiB | 986.80 KiB | 963.05 KiB |
Previous results on branch: sentrySwizzleWrapperSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6a8c688 | 1222.09 ms | 1255.15 ms | 33.06 ms |
bff9404 | 1222.56 ms | 1253.59 ms | 31.04 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6a8c688 | 23.75 KiB | 1008.52 KiB | 984.77 KiB |
bff9404 | 23.75 KiB | 1008.59 KiB | 984.84 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a small question
15114ed
to
6fdb51b
Compare
6fdb51b
to
51a4fd9
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Closes https://linear.app/getsentry/issue/COCOA-539/convert-sentryswizzlewrapper-to-swift
#skip-changelog