Skip to content

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 15, 2025

I realized the dependency container header declared this function to return SentryWatchdogTerminationScopeObserver but really all that it needed was to be a type conforming to SentryScopeObserver . So updated it to this protocol, it will make the Swift conversion easier

#skip-changelog

Closes #6424

Copy link

codecov bot commented Oct 15, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
3970 1 3969 11
View the top 3 failed test(s) by shortest run time
iOS_Swift_UITests.LaunchUITests::testNavigationTransaction
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:153 - Failed to get matching snapshot: Timed out while evaluating UI query.
iOS_Swift_UITests.UserFeedbackUITests::testCancelFromFormByButton
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/UserFeedbackUITests.swift:613 - XCTAssertTrue failed - Expected file to exist at .../27E7F335-C0DB-4FA8-B65A-E0E2CA575A52/Library/Application Support/io.sentry/feedback/onFormClose
iOS_Swift_UITests.ViewLifecycleUITests::testViewLifecycle_callingDismissWithViewWillDisappear_shouldNotCrashSDK
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/BaseUITest.swift:63 - Failed to terminate io.sentry.sample.iOS-Swift:28455: Failed to terminate io.sentry.sample.iOS-Swift:0

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.83 ms 1262.28 ms 35.45 ms
Size 23.75 KiB 995.60 KiB 971.85 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e3767a1 1224.20 ms 1257.16 ms 32.96 ms
b115f82 1212.96 ms 1251.92 ms 38.96 ms
438caec 1230.02 ms 1250.00 ms 19.98 ms
7d23639 1237.93 ms 1243.04 ms 5.11 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
5200f5b 1231.73 ms 1254.35 ms 22.62 ms
701acf0 1230.24 ms 1255.60 ms 25.36 ms
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
80538ca 1216.70 ms 1253.92 ms 37.22 ms
884b224 1233.41 ms 1259.50 ms 26.09 ms

App size

Revision Plain With Sentry Diff
e3767a1 23.75 KiB 913.14 KiB 889.39 KiB
b115f82 23.75 KiB 989.04 KiB 965.30 KiB
438caec 23.74 KiB 913.14 KiB 889.40 KiB
7d23639 23.75 KiB 891.01 KiB 867.26 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
5200f5b 23.75 KiB 933.33 KiB 909.58 KiB
701acf0 23.75 KiB 987.96 KiB 964.21 KiB
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
80538ca 23.75 KiB 989.99 KiB 966.24 KiB
884b224 23.75 KiB 879.60 KiB 855.86 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when CI is green.

@noahsmartin noahsmartin merged commit 23b6a91 into main Oct 15, 2025
207 of 213 checks passed
@noahsmartin noahsmartin deleted the updateScopeObserver branch October 15, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ref: Use scope observer protocol in dependency container

2 participants