Skip to content

Conversation

noahsmartin
Copy link
Contributor

Copy link

linear bot commented Oct 14, 2025

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.925%. Comparing base (23b6a91) to head (cc654b4).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6422       +/-   ##
=============================================
+ Coverage   86.702%   86.925%   +0.223%     
=============================================
  Files          445       446        +1     
  Lines        37510     37523       +13     
  Branches     17448     17453        +5     
=============================================
+ Hits         32522     32617       +95     
+ Misses        4943      4633      -310     
- Partials        45       273      +228     
Files with missing lines Coverage Δ
.../SentryDefaultUIViewControllerPerformanceTracker.m 98.982% <100.000%> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.163% <100.000%> (ø)
Sources/Sentry/SentryHub.m 96.666% <ø> (ø)
...rces/Sentry/SentryPerformanceTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentrySDKInternal.m 87.500% <ø> (ø)
Sources/Sentry/SentryTracer.m 97.704% <ø> (-0.492%) ⬇️
Sources/Sentry/SentryUIViewControllerSwizzling.m 92.000% <100.000%> (ø)
Sources/SentrySwiftUI/SentryTracedView.swift 70.000% <100.000%> (-0.371%) ⬇️
...nce/SentryUIViewControllerPerformanceTracker.swift 100.000% <100.000%> (ø)

... and 38 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23b6a91...cc654b4. Read the comment docs.

@noahsmartin noahsmartin force-pushed the sentryUIViewControllerPerformanceTrackerSwift branch 2 times, most recently from cb80daa to a0eeda9 Compare October 14, 2025 22:44
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.65 ms 1263.85 ms 33.20 ms
Size 23.75 KiB 1006.50 KiB 982.75 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a9fac2e 1212.45 ms 1219.67 ms 7.22 ms
ebc3a34 1236.24 ms 1261.02 ms 24.78 ms
e4ba9a7 1219.82 ms 1230.89 ms 11.07 ms
7b08a87 1220.14 ms 1246.10 ms 25.96 ms
1a34ddc 1217.79 ms 1242.17 ms 24.38 ms
5d238d3 1228.94 ms 1253.04 ms 24.10 ms
7af87c1 1229.31 ms 1253.84 ms 24.53 ms
4bf98bf 1219.13 ms 1244.50 ms 25.38 ms
d0f70ce 1226.54 ms 1247.04 ms 20.50 ms
1a4afd3 1224.39 ms 1246.16 ms 21.77 ms

App size

Revision Plain With Sentry Diff
a9fac2e 23.75 KiB 879.53 KiB 855.78 KiB
ebc3a34 23.75 KiB 919.91 KiB 896.16 KiB
e4ba9a7 23.75 KiB 969.22 KiB 945.47 KiB
7b08a87 23.74 KiB 913.70 KiB 889.95 KiB
1a34ddc 23.75 KiB 919.90 KiB 896.15 KiB
5d238d3 23.75 KiB 913.62 KiB 889.88 KiB
7af87c1 23.75 KiB 933.34 KiB 909.59 KiB
4bf98bf 23.75 KiB 919.70 KiB 895.95 KiB
d0f70ce 23.75 KiB 913.09 KiB 889.34 KiB
1a4afd3 23.75 KiB 997.18 KiB 973.43 KiB

Previous results on branch: sentryUIViewControllerPerformanceTrackerSwift

Startup times

Revision Plain With Sentry Diff
bcd00b0 1233.80 ms 1269.90 ms 36.10 ms
9011021 1219.69 ms 1250.46 ms 30.77 ms

App size

Revision Plain With Sentry Diff
bcd00b0 23.75 KiB 996.93 KiB 973.18 KiB
9011021 23.75 KiB 996.92 KiB 973.17 KiB

@noahsmartin noahsmartin force-pushed the sentryUIViewControllerPerformanceTrackerSwift branch 3 times, most recently from d4de525 to 3373fa8 Compare October 15, 2025 02:11
@noahsmartin noahsmartin marked this pull request as ready for review October 15, 2025 03:03
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@noahsmartin noahsmartin force-pushed the sentryUIViewControllerPerformanceTrackerSwift branch from 3373fa8 to cc654b4 Compare October 15, 2025 13:53
Copy link
Contributor

github-actions bot commented Oct 15, 2025

🚨 Detected changes in high risk code 🚨

High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:

  • Sources/Sentry/SentryUIViewControllerSwizzling.m

@noahsmartin noahsmartin merged commit 089769b into main Oct 15, 2025
197 of 199 checks passed
@noahsmartin noahsmartin deleted the sentryUIViewControllerPerformanceTrackerSwift branch October 15, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants