-
-
Notifications
You must be signed in to change notification settings - Fork 366
ref: SentryUIViewControllerPerformanceTracker in Swift #6422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: SentryUIViewControllerPerformanceTracker in Swift #6422
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6422 +/- ##
=============================================
+ Coverage 86.702% 86.925% +0.223%
=============================================
Files 445 446 +1
Lines 37510 37523 +13
Branches 17448 17453 +5
=============================================
+ Hits 32522 32617 +95
+ Misses 4943 4633 -310
- Partials 45 273 +228
... and 38 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cb80daa
to
a0eeda9
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9fac2e | 1212.45 ms | 1219.67 ms | 7.22 ms |
ebc3a34 | 1236.24 ms | 1261.02 ms | 24.78 ms |
e4ba9a7 | 1219.82 ms | 1230.89 ms | 11.07 ms |
7b08a87 | 1220.14 ms | 1246.10 ms | 25.96 ms |
1a34ddc | 1217.79 ms | 1242.17 ms | 24.38 ms |
5d238d3 | 1228.94 ms | 1253.04 ms | 24.10 ms |
7af87c1 | 1229.31 ms | 1253.84 ms | 24.53 ms |
4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
d0f70ce | 1226.54 ms | 1247.04 ms | 20.50 ms |
1a4afd3 | 1224.39 ms | 1246.16 ms | 21.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a9fac2e | 23.75 KiB | 879.53 KiB | 855.78 KiB |
ebc3a34 | 23.75 KiB | 919.91 KiB | 896.16 KiB |
e4ba9a7 | 23.75 KiB | 969.22 KiB | 945.47 KiB |
7b08a87 | 23.74 KiB | 913.70 KiB | 889.95 KiB |
1a34ddc | 23.75 KiB | 919.90 KiB | 896.15 KiB |
5d238d3 | 23.75 KiB | 913.62 KiB | 889.88 KiB |
7af87c1 | 23.75 KiB | 933.34 KiB | 909.59 KiB |
4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
d0f70ce | 23.75 KiB | 913.09 KiB | 889.34 KiB |
1a4afd3 | 23.75 KiB | 997.18 KiB | 973.43 KiB |
Previous results on branch: sentryUIViewControllerPerformanceTrackerSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bcd00b0 | 1233.80 ms | 1269.90 ms | 36.10 ms |
9011021 | 1219.69 ms | 1250.46 ms | 30.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bcd00b0 | 23.75 KiB | 996.93 KiB | 973.18 KiB |
9011021 | 23.75 KiB | 996.92 KiB | 973.17 KiB |
d4de525
to
3373fa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
3373fa8
to
cc654b4
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Closes https://linear.app/getsentry/issue/COCOA-713/convert-sentryuiviewcontrollerperformancetracker
#skip-changelog