Skip to content

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 10, 2025

CI on v8 fails with

Run ./scripts/ci-select-xcode.sh 26.0
Available Xcode versions:
1) 16.4 (16F6)
2) 26.0.1 (17A400) (Selected)
3) 26.1 Beta (17B5025f)
Enter the number of the Xcode to select: Not a valid number. Expecting a whole number between 1-3, but given nothing.
Error: Process completed with exit code 1.

This fixes that problem by using Xcode 26.0.1.

#skip-changelog

Closes #6395

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.804%. Comparing base (b66be9b) to head (c218e1c).
⚠️ Report is 1 commits behind head on v8.x.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              v8.x     #6394       +/-   ##
=============================================
+ Coverage   86.796%   86.804%   +0.008%     
=============================================
  Files          438       438               
  Lines        37345     37345               
  Branches     17465     17466        +1     
=============================================
+ Hits         32414     32417        +3     
+ Misses        4888      4884        -4     
- Partials        43        44        +1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b66be9b...c218e1c. Read the comment docs.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.44 ms 1261.59 ms 28.15 ms
Size 23.75 KiB 996.03 KiB 972.29 KiB

Baseline results on branch: v8.x

Startup times

Revision Plain With Sentry Diff
c6afcc7 1224.31 ms 1256.22 ms 31.92 ms
b66be9b 1218.22 ms 1244.19 ms 25.96 ms

App size

Revision Plain With Sentry Diff
c6afcc7 23.75 KiB 996.03 KiB 972.28 KiB
b66be9b 23.75 KiB 996.03 KiB 972.28 KiB

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@philipphofmann philipphofmann enabled auto-merge (squash) October 10, 2025 05:36
@philipphofmann philipphofmann merged commit a7a0a2b into v8.x Oct 10, 2025
168 of 171 checks passed
@philipphofmann philipphofmann deleted the ci/bump-xcode-26 branch October 10, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants