Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 9, 2025

Some tests have run for more than 2 hours: https://github.com/getsentry/sentry-cocoa/actions/runs/18385712036/job/52383740960

This will avoid the issue with a loose timeout

#skip-changelog

Closes #6392

Copy link
Contributor

github-actions bot commented Oct 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.46 ms 1264.16 ms 28.70 ms
Size 23.75 KiB 988.01 KiB 964.27 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
51b7dd3 1235.06 ms 1258.21 ms 23.15 ms
6cb4338 1238.47 ms 1256.96 ms 18.49 ms
397b9c9 1230.23 ms 1249.29 ms 19.06 ms
7273bf4 1202.42 ms 1227.62 ms 25.21 ms
9a32d52 1215.69 ms 1236.85 ms 21.16 ms
d06a4db 1233.20 ms 1243.18 ms 9.98 ms
6e99155 1223.96 ms 1249.25 ms 25.29 ms
4267263 1233.13 ms 1266.13 ms 33.00 ms
d637379 1226.43 ms 1250.77 ms 24.34 ms
ed85746 1231.79 ms 1248.55 ms 16.75 ms

App size

Revision Plain With Sentry Diff
51b7dd3 23.75 KiB 913.26 KiB 889.52 KiB
6cb4338 23.75 KiB 913.63 KiB 889.88 KiB
397b9c9 23.75 KiB 959.44 KiB 935.70 KiB
7273bf4 23.75 KiB 908.01 KiB 884.26 KiB
9a32d52 23.75 KiB 981.29 KiB 957.54 KiB
d06a4db 23.75 KiB 913.18 KiB 889.43 KiB
6e99155 23.75 KiB 963.18 KiB 939.43 KiB
4267263 23.75 KiB 988.03 KiB 964.28 KiB
d637379 23.75 KiB 855.38 KiB 831.63 KiB
ed85746 23.75 KiB 920.83 KiB 897.08 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 701acf0 into main Oct 10, 2025
138 of 142 checks passed
@philipphofmann philipphofmann deleted the itay/add_timeout_tests branch October 10, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Add timeout to UI tests

2 participants