-
-
Notifications
You must be signed in to change notification settings - Fork 368
fix: Fix thread deallocation #6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6375 +/- ##
=============================================
- Coverage 86.744% 86.731% -0.014%
=============================================
Files 439 439
Lines 37238 37238
Branches 17368 17360 -8
=============================================
- Hits 32302 32297 -5
- Misses 4891 4896 +5
Partials 45 45
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When fixing the h
issue. LGTM
Sources/SentryCrash/Recording/Tools/SentryCrashMachineContext.c
Outdated
Show resolved
Hide resolved
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a4c5ddc | 1239.61 ms | 1266.41 ms | 26.80 ms |
08fc5f9 | 1237.84 ms | 1270.06 ms | 32.23 ms |
f5666e7 | 1227.08 ms | 1260.18 ms | 33.10 ms |
7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
d3f650a | 1225.45 ms | 1241.86 ms | 16.41 ms |
c122943 | 1210.94 ms | 1233.78 ms | 22.84 ms |
cc7f629 | 1226.00 ms | 1245.51 ms | 19.51 ms |
d66f082 | 1227.08 ms | 1247.04 ms | 19.96 ms |
04ff3ec | 1220.71 ms | 1253.86 ms | 33.15 ms |
7b3399c | 1193.35 ms | 1227.38 ms | 34.03 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a4c5ddc | 23.75 KiB | 977.30 KiB | 953.55 KiB |
08fc5f9 | 23.75 KiB | 995.43 KiB | 971.68 KiB |
f5666e7 | 23.75 KiB | 963.18 KiB | 939.43 KiB |
7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
d3f650a | 23.75 KiB | 902.48 KiB | 878.73 KiB |
c122943 | 23.74 KiB | 926.65 KiB | 902.90 KiB |
cc7f629 | 23.75 KiB | 878.48 KiB | 854.73 KiB |
d66f082 | 23.75 KiB | 928.85 KiB | 905.10 KiB |
04ff3ec | 23.75 KiB | 880.26 KiB | 856.52 KiB |
7b3399c | 23.75 KiB | 946.68 KiB | 922.94 KiB |
Thread deallocation logic is only deallocating thread in the context
#skip-changelog
Closes #6376
Fixes #5908