Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 7, 2025

Thread deallocation logic is only deallocating thread in the context

#skip-changelog

Closes #6376
Fixes #5908

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.731%. Comparing base (d72784d) to head (9863452).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6375       +/-   ##
=============================================
- Coverage   86.744%   86.731%   -0.014%     
=============================================
  Files          439       439               
  Lines        37238     37238               
  Branches     17368     17360        -8     
=============================================
- Hits         32302     32297        -5     
- Misses        4891      4896        +5     
  Partials        45        45               
Files with missing lines Coverage Δ
...yCrash/Recording/Tools/SentryCrashMachineContext.c 80.745% <100.000%> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72784d...9863452. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When fixing the h issue. LGTM

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.78 ms 1254.22 ms 25.44 ms
Size 23.75 KiB 988.02 KiB 964.27 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a4c5ddc 1239.61 ms 1266.41 ms 26.80 ms
08fc5f9 1237.84 ms 1270.06 ms 32.23 ms
f5666e7 1227.08 ms 1260.18 ms 33.10 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms
d3f650a 1225.45 ms 1241.86 ms 16.41 ms
c122943 1210.94 ms 1233.78 ms 22.84 ms
cc7f629 1226.00 ms 1245.51 ms 19.51 ms
d66f082 1227.08 ms 1247.04 ms 19.96 ms
04ff3ec 1220.71 ms 1253.86 ms 33.15 ms
7b3399c 1193.35 ms 1227.38 ms 34.03 ms

App size

Revision Plain With Sentry Diff
a4c5ddc 23.75 KiB 977.30 KiB 953.55 KiB
08fc5f9 23.75 KiB 995.43 KiB 971.68 KiB
f5666e7 23.75 KiB 963.18 KiB 939.43 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB
d3f650a 23.75 KiB 902.48 KiB 878.73 KiB
c122943 23.74 KiB 926.65 KiB 902.90 KiB
cc7f629 23.75 KiB 878.48 KiB 854.73 KiB
d66f082 23.75 KiB 928.85 KiB 905.10 KiB
04ff3ec 23.75 KiB 880.26 KiB 856.52 KiB
7b3399c 23.75 KiB 946.68 KiB 922.94 KiB

Previous results on branch: itay/deallocate_fix

Startup times

Revision Plain With Sentry Diff
be74dd9 1217.48 ms 1258.21 ms 40.74 ms

App size

Revision Plain With Sentry Diff
be74dd9 23.75 KiB 991.85 KiB 968.10 KiB

Base automatically changed from itay/tests_sentry_crash to main October 9, 2025 17:29
@itaybre itaybre merged commit f4f94f5 into main Oct 9, 2025
178 of 180 checks passed
@itaybre itaybre deleted the itay/deallocate_fix branch October 9, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: Fix thread deallocation Probably a mistake in function getThreadList

2 participants