-
-
Notifications
You must be signed in to change notification settings - Fork 368
chore: Add tests for SentryCrashContext #6373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6373 +/- ##
========================================
Coverage ? 86.779%
========================================
Files ? 439
Lines ? 37238
Branches ? 17364
========================================
Hits ? 32315
Misses ? 4877
Partials ? 46
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests don't cleanup the threads. We need to fix that. Otherwise, we might end up with flaky tests.
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8da57d | 1203.77 ms | 1234.85 ms | 31.08 ms |
aff3b66 | 1229.53 ms | 1263.08 ms | 33.55 ms |
e0424b9 | 1204.23 ms | 1241.08 ms | 36.85 ms |
6d40fee | 1217.47 ms | 1245.37 ms | 27.90 ms |
99ec589 | 1209.73 ms | 1231.98 ms | 22.24 ms |
854ca12 | 1219.94 ms | 1251.32 ms | 31.38 ms |
3ffd0e5 | 1228.04 ms | 1253.04 ms | 25.00 ms |
6279992 | 1213.60 ms | 1241.38 ms | 27.79 ms |
2b02431 | 1229.63 ms | 1248.98 ms | 19.35 ms |
b9aacb6 | 1230.42 ms | 1251.00 ms | 20.58 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e8da57d | 23.75 KiB | 919.69 KiB | 895.94 KiB |
aff3b66 | 23.75 KiB | 978.53 KiB | 954.78 KiB |
e0424b9 | 23.74 KiB | 874.07 KiB | 850.33 KiB |
6d40fee | 23.75 KiB | 912.37 KiB | 888.63 KiB |
99ec589 | 23.75 KiB | 983.31 KiB | 959.57 KiB |
854ca12 | 23.74 KiB | 996.96 KiB | 973.22 KiB |
3ffd0e5 | 23.75 KiB | 947.55 KiB | 923.80 KiB |
6279992 | 23.75 KiB | 891.03 KiB | 867.28 KiB |
2b02431 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
b9aacb6 | 23.75 KiB | 913.64 KiB | 889.89 KiB |
Adds a couple of tests before adding some modifications
Shame on me, but using ObjC for tests since that allows me to use the macros
#skip-changelog
Closes #6374