Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Oct 7, 2025

Adds a couple of tests before adding some modifications

Shame on me, but using ObjC for tests since that allows me to use the macros

#skip-changelog

Closes #6374

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ba80daf). Learn more about missing BASE report.
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #6373   +/-   ##
========================================
  Coverage        ?   86.779%           
========================================
  Files           ?       439           
  Lines           ?     37238           
  Branches        ?     17364           
========================================
  Hits            ?     32315           
  Misses          ?      4877           
  Partials        ?        46           
Files with missing lines Coverage Δ
.../Recording/Tools/SentryCrashMachineContext_Apple.h 100.000% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba80daf...b5a8ee4. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests don't cleanup the threads. We need to fix that. Otherwise, we might end up with flaky tests.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.67 ms 1269.61 ms 34.94 ms
Size 23.75 KiB 988.01 KiB 964.26 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e8da57d 1203.77 ms 1234.85 ms 31.08 ms
aff3b66 1229.53 ms 1263.08 ms 33.55 ms
e0424b9 1204.23 ms 1241.08 ms 36.85 ms
6d40fee 1217.47 ms 1245.37 ms 27.90 ms
99ec589 1209.73 ms 1231.98 ms 22.24 ms
854ca12 1219.94 ms 1251.32 ms 31.38 ms
3ffd0e5 1228.04 ms 1253.04 ms 25.00 ms
6279992 1213.60 ms 1241.38 ms 27.79 ms
2b02431 1229.63 ms 1248.98 ms 19.35 ms
b9aacb6 1230.42 ms 1251.00 ms 20.58 ms

App size

Revision Plain With Sentry Diff
e8da57d 23.75 KiB 919.69 KiB 895.94 KiB
aff3b66 23.75 KiB 978.53 KiB 954.78 KiB
e0424b9 23.74 KiB 874.07 KiB 850.33 KiB
6d40fee 23.75 KiB 912.37 KiB 888.63 KiB
99ec589 23.75 KiB 983.31 KiB 959.57 KiB
854ca12 23.74 KiB 996.96 KiB 973.22 KiB
3ffd0e5 23.75 KiB 947.55 KiB 923.80 KiB
6279992 23.75 KiB 891.03 KiB 867.28 KiB
2b02431 23.75 KiB 850.73 KiB 826.98 KiB
b9aacb6 23.75 KiB 913.64 KiB 889.89 KiB

Previous results on branch: itay/tests_sentry_crash

Startup times

Revision Plain With Sentry Diff
59e824b 1221.24 ms 1254.35 ms 33.11 ms

App size

Revision Plain With Sentry Diff
59e824b 23.75 KiB 986.80 KiB 963.05 KiB

@itaybre itaybre enabled auto-merge (squash) October 9, 2025 17:06
@itaybre itaybre merged commit d72784d into main Oct 9, 2025
191 of 198 checks passed
@itaybre itaybre deleted the itay/tests_sentry_crash branch October 9, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Add tests for SentryCrashContext

3 participants