Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Oct 6, 2025

📜 Description

Structured Logs: Move options out of experimental

💡 Motivation and Context

Closes #6013

💚 How did you test it?

Running CI

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@denrase denrase marked this pull request as ready for review October 6, 2025 09:30
Copy link

codecov bot commented Oct 6, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4011 1 4010 31
View the top 3 failed test(s) by shortest run time
iOS_SwiftUI_UITests.LaunchUITests::testCaptureErrorReturnsValidId
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:56 - Failed to tap "Capture Error" Button: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testCheckTotalFrames
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:78 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.
iOS_Swift_UITests.LaunchUITests::testShowNib
Stack Traces | 0s run time
.../iOS-Swift/iOS-Swift-UITests/LaunchUITests.swift:27 - Failed to Error Domain=com.apple.dt.XCTest.XCTFuture Code=1000 "Timed out while evaluating UI query." UserInfo={NSLocalizedDescription=Timed out while evaluating UI query.}: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

@noahsmartin noahsmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think before we do this we should make sure default stdout collection is turned on so that doesn’t need to done in a new major version

@philipphofmann
Copy link
Member

I think before we do this we should make sure default stdout collection is turned on so that doesn’t need to done in a new major version

Fair point. We can also create an issue to follow up with this, merge the PR and then ensure we don't release without ⬆️ The issue could be in the essential issues for V9 milestone in Linear.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Oct 8, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.06 ms 1259.50 ms 35.44 ms
Size 23.75 KiB 1004.79 KiB 981.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e3767a1 1224.20 ms 1257.16 ms 32.96 ms
b115f82 1212.96 ms 1251.92 ms 38.96 ms
438caec 1230.02 ms 1250.00 ms 19.98 ms
7d23639 1237.93 ms 1243.04 ms 5.11 ms
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
5200f5b 1231.73 ms 1254.35 ms 22.62 ms
701acf0 1230.24 ms 1255.60 ms 25.36 ms
2675d3c 1218.94 ms 1239.36 ms 20.42 ms
80538ca 1216.70 ms 1253.92 ms 37.22 ms
884b224 1233.41 ms 1259.50 ms 26.09 ms

App size

Revision Plain With Sentry Diff
e3767a1 23.75 KiB 913.14 KiB 889.39 KiB
b115f82 23.75 KiB 989.04 KiB 965.30 KiB
438caec 23.74 KiB 913.14 KiB 889.40 KiB
7d23639 23.75 KiB 891.01 KiB 867.26 KiB
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
5200f5b 23.75 KiB 933.33 KiB 909.58 KiB
701acf0 23.75 KiB 987.96 KiB 964.21 KiB
2675d3c 23.75 KiB 928.16 KiB 904.41 KiB
80538ca 23.75 KiB 989.99 KiB 966.24 KiB
884b224 23.75 KiB 879.60 KiB 855.86 KiB

Previous results on branch: denrase/structured-logs-out-of-experimental

Startup times

Revision Plain With Sentry Diff
3705042 1217.00 ms 1240.06 ms 23.06 ms
d570a8e 1222.16 ms 1253.17 ms 31.00 ms
62b88af 1227.71 ms 1260.82 ms 33.11 ms
60ed5fd 1233.49 ms 1265.63 ms 32.14 ms

App size

Revision Plain With Sentry Diff
3705042 23.75 KiB 986.87 KiB 963.12 KiB
d570a8e 23.75 KiB 994.85 KiB 971.10 KiB
62b88af 23.75 KiB 994.84 KiB 971.10 KiB
60ed5fd 23.75 KiB 994.85 KiB 971.10 KiB

@denrase
Copy link
Collaborator Author

denrase commented Oct 8, 2025

@philipphofmann Also added beforeSendLog to SentryOptionsTest

@denrase
Copy link
Collaborator Author

denrase commented Oct 8, 2025

@philipphofmann Do you have any idea why the public API job is failing? I did run & commit make generate-public-api

@denrase
Copy link
Collaborator Author

denrase commented Oct 8, 2025

Cross platform is failing because this is breaking API.

@philipphofmann
Copy link
Member

philipphofmann commented Oct 10, 2025

@philipphofmann Do you have any idea why the public API job is failing? I did run & commit make generate-public-api

You have to run it with Xcode 16. make generate-public-api. I also made the same mistake in another PR. I opened a PR to let the script fail if you're not running it with Xcode 16 #6396.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @denrase. Please create a follow up issue for #6359 (review) and link it in Linear as mentioned here #6359 (comment). Then we can merge this.

@denrase
Copy link
Collaborator Author

denrase commented Oct 13, 2025

@philipphofmann Added #6411.

@denrase denrase enabled auto-merge (squash) October 14, 2025 12:02
@denrase denrase disabled auto-merge October 14, 2025 12:02
# Conflicts:
#	Sources/Swift/SentryExperimentalOptions.swift
#	sdk_api.json
@denrase denrase merged commit f5d75da into main Oct 15, 2025
177 of 180 checks passed
@denrase denrase deleted the denrase/structured-logs-out-of-experimental branch October 15, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Structured Logs: Move options out of experimental

3 participants