fix(replay): Don't capture replays for events dropped in beforeSend

[romtsn]

📜 Description

• Reorder eventProcessors with beforeSend so if the event is dropped in beforeSend the processors are not called
  • This is currently only used in one place for SessionReplay and we don't expose it to customers, so it shouldn't break any existing behavior
  • I created Improve GlobalEventProcessor #5915 to improve this, and depending on the decision made there we might have to ditch the event processors or document the order.

💡 Motivation and Context

Closes #5735

💚 How did you test it?

Manually + automated

📝 Checklist

You have to check all boxes before merging:

• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• I updated the wizard if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

[codecov]

❌ 13 Tests Failed:

Tests completed	Failed	Passed	Skipped
32036	13	32023	97

View the top 3 failed test(s) by shortest run time

iOS_Swift_UITests.TopViewControllerTests::testNavigationViewController

Stack Traces | 0s run time

.../iOS-Swift/iOS-Swift-UITests/TopViewControllerTests.swift:29 - XCTAssertEqual failed: ("") is not equal to ("TableViewController")

iOS_Swift_UITests.TopViewControllerTests::testNavigationViewController

Stack Traces | 0s run time

.../iOS-Swift/iOS-Swift-UITests/TopViewControllerTests.swift:29 - XCTAssertEqual failed: ("") is not equal to ("TableViewController")

iOS_Swift_UITests.TopViewControllerTests::testPagesViewController

Stack Traces | 0s run time

.../iOS-Swift/iOS-Swift-UITests/TopViewControllerTests.swift:61 - XCTAssertEqual failed: ("") is not equal to ("RedViewController")

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1214.20 ms	1245.65 ms	31.45 ms
Size	23.75 KiB	920.64 KiB	896.89 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
65ebbdb	1233.96 ms	1255.79 ms	21.83 ms
8d944ac	1236.92 ms	1254.91 ms	18.00 ms
9be5373	1215.92 ms	1239.44 ms	23.52 ms
5196f0d	1213.35 ms	1231.37 ms	18.02 ms
64c2b2b	1233.96 ms	1260.20 ms	26.24 ms
2a7868a	1226.54 ms	1256.92 ms	30.37 ms
ebc72be	1221.24 ms	1249.66 ms	28.42 ms
9e6569a	1216.07 ms	1242.50 ms	26.43 ms
52f3b6e	1219.57 ms	1239.70 ms	20.13 ms
cd9727b	1236.04 ms	1254.41 ms	18.37 ms

App size

Revision	Plain	With Sentry	Diff
65ebbdb	23.75 KiB	902.33 KiB	878.59 KiB
8d944ac	23.75 KiB	919.69 KiB	895.94 KiB
9be5373	23.75 KiB	866.50 KiB	842.75 KiB
5196f0d	23.75 KiB	876.93 KiB	853.19 KiB
64c2b2b	23.75 KiB	908.55 KiB	884.80 KiB
2a7868a	23.75 KiB	880.20 KiB	856.45 KiB
ebc72be	23.75 KiB	908.22 KiB	884.47 KiB
9e6569a	23.75 KiB	904.54 KiB	880.79 KiB
52f3b6e	23.75 KiB	920.54 KiB	896.79 KiB
cd9727b	23.75 KiB	879.25 KiB	855.51 KiB

[ohwhen]

👀

[philipphofmann]

Thanks, LGTM with a few comments.

[philprime]

LGTM, same feedback as @philipphofmann

[philipphofmann]

Thanks @romtsn