test: Add SwiftLint rule for using DispatchGroups #5904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace DispatchGroup with XCTextExpectation in SentryTracerTests.
Replace DispatchGroup with XCTextExpectation in SentryHttpTransportFlushIntegrationTests.
…iftlint-dispatchgroup
…st/swiftlint-dispatchgroup
Add a custom swift lint rule for using DispatchGroups in unit tests to ensure using XCTestExpectations instead. Fixes GH-5789
philprime
approved these changes
Aug 13, 2025
Base automatically changed from
test/use-xctestexcpectation-sentry-tracer
to
main
August 13, 2025 08:32
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5904 +/- ##
=============================================
+ Coverage 86.393% 86.675% +0.281%
=============================================
Files 417 423 +6
Lines 36197 36550 +353
Branches 15396 17295 +1899
=============================================
+ Hits 31272 31680 +408
+ Misses 4882 4823 -59
- Partials 43 47 +4 see 57 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #5902 and #5903. We must merge these before merging this PR.
Add a custom Swift lint rule for using DispatchGroups in unit tests to
ensure using XCTestExpectations instead.
Fixes #5789