Skip to content

Conversation

itaybre
Copy link
Contributor

@itaybre itaybre commented Aug 12, 2025

Found swifltint linting git files because I used Package.swift in a branch name

Linting '.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift' (153/154)
Linting '.git/logs/refs/remotes/origin/itaybre/add_new_slice_to_pacakge.swift' (154/154)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:3:174: error: Identifier Name Violation: Variable name 'Sentry' should start with a lowercase character (identifier_name)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:6:173: error: Identifier Name Violation: Variable name 'Sentry' should start with a lowercase character (identifier_name)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:1:1: error: Number Separator Violation: Underscores should be used as thousand separators (number_separator)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:1:42: error: Number Separator Violation: Underscores should be used as thousand separators (number_separator)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:3:180: error: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/heads/itaybre/add_new_slice_to_pacakge.swift:6:215: error: Opening Brace Spacing Violation: Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
/Users/itaybrenner/sentry/sentry-cocoa/.git/logs/refs/remotes/origin/itaybre/add_new_slice_to_pacakge.swift:1:1: error: Number Separator Violation: Underscores should be used as thousand separators (number_separator)

#skip-changelog

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had this committed in some PR too, didn't get a chance yet to create a separate PR.

@itaybre itaybre merged commit 3c86ff3 into main Aug 12, 2025
33 checks passed
@itaybre itaybre deleted the itaybre/exclude_git_folder_swiftlint branch August 12, 2025 13:44
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants