Fix sentry unwrap nullable macro type mismatch #5890
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Corrected the application of the
SENTRY_UNWRAP_NULLABLE
macro inSentryProfiler.mm
to directly unwrapconfigurationFromLaunch.profileOptions
.💡 Motivation and Context
The
SENTRY_UNWRAP_NULLABLE
macro was incorrectly attempting to unwrapconfigurationFromLaunch
(typeSentryProfileConfiguration *
) asSentryProfileOptions
, then accessing.profileOptions
on the result. This type mismatch could lead to compilation errors or runtime crashes. The change ensures the macro unwrapsconfigurationFromLaunch.profileOptions
(typeSentryProfileOptions *
) directly, resolving the issue.💚 How did you test it?
Verified that no other instances of the incorrect
SENTRY_UNWRAP_NULLABLE(SentryProfileOptions, configurationFromLaunch)
remained and that other related usages were already correct.📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.