Skip to content

Conversation

philprime
Copy link
Member

This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.

The async logger relies on a nullable static caches path, so we need to unwrap it before we check for existence. As we are already logging an error and exiting the method, when directory creation fails, I use the same approach when the cache directory is not defined.

#skip-changelog

Copy link

codecov bot commented Aug 12, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
31993 2 31991 97
View the top 1 failed test(s) by shortest run time
iOS_SwiftUI_UITests.LaunchUITests::testNoNewTransactionForSecondCallToBody
Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/LaunchUITests.swift:38 - Failed to get matching snapshot: Timed out while evaluating UI query.
View the full list of 1 ❄️ flaky tests
iOS_SwiftUI_UITests.FeedbackUITests::testWidgetDisplayInSwiftUIApp

Flake rate in main: 13.64% (Passed 57 times, Failed 9 times)

Stack Traces | 0s run time
.../iOS-SwiftUI/iOS-SwiftUI-UITests/FeedbackUITests.swift:14 - Failed to get matching snapshots: Timed out while evaluating UI query.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.82 ms 1246.94 ms 32.12 ms
Size 23.75 KiB 919.79 KiB 896.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ebc72be 1221.24 ms 1249.66 ms 28.42 ms
dad68ad 1229.15 ms 1261.98 ms 32.83 ms
aa0b738 1236.78 ms 1253.08 ms 16.31 ms
186f06f 1211.33 ms 1235.41 ms 24.08 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
64c2b2b 1233.96 ms 1260.20 ms 26.24 ms
15c8cd5 1220.24 ms 1246.14 ms 25.90 ms
b41e6a7 1201.65 ms 1246.12 ms 44.47 ms
018037b 1209.31 ms 1228.33 ms 19.03 ms
7908e84 1224.33 ms 1246.39 ms 22.06 ms

App size

Revision Plain With Sentry Diff
ebc72be 23.75 KiB 908.22 KiB 884.47 KiB
dad68ad 23.75 KiB 912.37 KiB 888.63 KiB
aa0b738 23.74 KiB 872.75 KiB 849.00 KiB
186f06f 23.75 KiB 876.94 KiB 853.19 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
64c2b2b 23.75 KiB 908.55 KiB 884.80 KiB
15c8cd5 23.75 KiB 908.01 KiB 884.26 KiB
b41e6a7 23.75 KiB 908.03 KiB 884.28 KiB
018037b 23.75 KiB 867.16 KiB 843.41 KiB
7908e84 23.74 KiB 872.75 KiB 849.00 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Aug 12, 2025
@philprime philprime merged commit 0822ad3 into main Aug 13, 2025
132 of 134 checks passed
@philprime philprime deleted the philprime/strict-nullability-12 branch August 13, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants