Skip to content

Conversation

philprime
Copy link
Member

This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.

Resolves warnings in tracing related files.

#skip-changelog

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@3c86ff3). Learn more about missing BASE report.
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryTraceContext.m 80.000% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #5888   +/-   ##
========================================
  Coverage        ?   86.666%           
========================================
  Files           ?       423           
  Lines           ?     36533           
  Branches        ?     17284           
========================================
  Hits            ?     31662           
  Misses          ?      4825           
  Partials        ?        46           
Files with missing lines Coverage Δ
Sources/Sentry/SentryTracer.m 97.704% <ø> (ø)
Sources/Sentry/SentryTraceContext.m 95.953% <80.000%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c86ff3...883f2fc. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Aug 12, 2025
@philprime philprime merged commit 9788cc8 into main Aug 13, 2025
164 of 169 checks passed
@philprime philprime deleted the philprime/strict-nullability-3 branch August 13, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants