-
-
Notifications
You must be signed in to change notification settings - Fork 366
refactor: Add null-handling to profiler #5887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5887 +/- ##
========================================
Coverage ? 86.628%
========================================
Files ? 423
Lines ? 36541
Branches ? 17282
========================================
Hits ? 31655
Misses ? 4838
Partials ? 48
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
4bf98bf | 1219.13 ms | 1244.50 ms | 25.38 ms |
8047b99 | 1226.37 ms | 1246.63 ms | 20.26 ms |
7416ffc | 1225.55 ms | 1241.80 ms | 16.25 ms |
7f2f69c | 1237.61 ms | 1266.96 ms | 29.35 ms |
ad964ca | 1234.73 ms | 1254.88 ms | 20.15 ms |
07d7e83 | 1211.71 ms | 1240.08 ms | 28.37 ms |
db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
2a7868a | 1226.54 ms | 1256.92 ms | 30.37 ms |
605fa27 | 1226.31 ms | 1251.35 ms | 25.05 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
4bf98bf | 23.75 KiB | 919.70 KiB | 895.95 KiB |
8047b99 | 23.75 KiB | 855.37 KiB | 831.62 KiB |
7416ffc | 23.75 KiB | 913.63 KiB | 889.88 KiB |
7f2f69c | 23.75 KiB | 913.38 KiB | 889.63 KiB |
ad964ca | 23.75 KiB | 913.17 KiB | 889.42 KiB |
07d7e83 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
2a7868a | 23.75 KiB | 880.20 KiB | 856.45 KiB |
605fa27 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
Previous results on branch: philprime/strict-nullability-2
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
53acbb6 | 1237.47 ms | 1260.63 ms | 23.16 ms |
a870df8 | 1214.54 ms | 1232.81 ms | 18.27 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
53acbb6 | 23.75 KiB | 908.17 KiB | 884.42 KiB |
a870df8 | 23.75 KiB | 908.23 KiB | 884.49 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.
Resolves warnings in SentryProfiledTracerConcurrency.mm and SentryProfiler.mm
#skip-changelog