-
-
Notifications
You must be signed in to change notification settings - Fork 366
refactor: Use null handling in SentryUIApplication.m #5886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Bugbot reviewed your changes and found no bugs!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5886 +/- ##
=============================================
- Coverage 86.681% 86.676% -0.005%
=============================================
Files 423 423
Lines 36505 36508 +3
Branches 17273 17272 -1
=============================================
+ Hits 31643 31644 +1
Misses 4817 4817
- Partials 45 47 +2
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
dad68ad | 1229.15 ms | 1261.98 ms | 32.83 ms |
aa0b738 | 1236.78 ms | 1253.08 ms | 16.31 ms |
186f06f | 1211.33 ms | 1235.41 ms | 24.08 ms |
9be5373 | 1215.92 ms | 1239.44 ms | 23.52 ms |
64c2b2b | 1233.96 ms | 1260.20 ms | 26.24 ms |
15c8cd5 | 1220.24 ms | 1246.14 ms | 25.90 ms |
b41e6a7 | 1201.65 ms | 1246.12 ms | 44.47 ms |
018037b | 1209.31 ms | 1228.33 ms | 19.03 ms |
7908e84 | 1224.33 ms | 1246.39 ms | 22.06 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
dad68ad | 23.75 KiB | 912.37 KiB | 888.63 KiB |
aa0b738 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
186f06f | 23.75 KiB | 876.94 KiB | 853.19 KiB |
9be5373 | 23.75 KiB | 866.50 KiB | 842.75 KiB |
64c2b2b | 23.75 KiB | 908.55 KiB | 884.80 KiB |
15c8cd5 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
b41e6a7 | 23.75 KiB | 908.03 KiB | 884.28 KiB |
018037b | 23.75 KiB | 867.16 KiB | 843.41 KiB |
7908e84 | 23.74 KiB | 872.75 KiB | 849.00 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…etsentry#5886)" This reverts commit 3efaf5e.
…etsentry#5886)" This reverts commit 3efaf5e.
This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.
Resolves warnings in SentryUIApplication.m
#skip-changelog