Skip to content

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Aug 12, 2025

Use dorny path filters to have one single job failing or succeeding when the unit tests passed or were skipped so we can enable unit tests as required checks for PRs.

Fixes GH-5868

PR with only a Changelog entry let's the job unit test pass #5891.

Screenshot 2025-08-12 at 13 19 31

When cancelling unit tests jobs fail

https://github.com/getsentry/sentry-cocoa/actions/runs/16907162839/job/47899511411

Screenshot 2025-08-12 at 13 21 18

When a few unit tests fail also the main unit test job fails

Screenshot 2025-08-12 at 14 46 52

#skip-changelog

Use dorny path filters to have one single job failing or succeeding when
the unit tests passed or were skipped so we can enable unit tests
as required checks for PRs.

Fixes GH-5868
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.681%. Comparing base (f37e3fe) to head (e0e10cc).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5885       +/-   ##
=============================================
+ Coverage   86.656%   86.681%   +0.024%     
=============================================
  Files          423       423               
  Lines        36505     36505               
  Branches     17274     17277        +3     
=============================================
+ Hits         31634     31643        +9     
+ Misses        4824      4815        -9     
  Partials        47        47               

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37e3fe...e0e10cc. Read the comment docs.

@philipphofmann philipphofmann marked this pull request as ready for review August 12, 2025 12:47
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's give this a shot and fix it ASAP if we get blocked.

@philipphofmann philipphofmann merged commit 7a1d56c into main Aug 12, 2025
27 checks passed
@philipphofmann philipphofmann deleted the ci/unit-test-required-check branch August 12, 2025 13:02
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Mark Unit Tests as required checks for PRs

2 participants