Skip to content

Conversation

philipphofmann
Copy link
Member

Add a regression test for GH-5334 by checking that captured non fatal events have debug meta attached.

Fixes GH-5575

#skip-changelog

Add a regression test for GH-5334 by checking that captured non fatal
events have debug meta attached.

Fixes GH-5575
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.664%. Comparing base (f37e3fe) to head (7ba898e).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5884       +/-   ##
=============================================
+ Coverage   86.656%   86.664%   +0.008%     
=============================================
  Files          423       423               
  Lines        36505     36505               
  Branches     17274     17278        +4     
=============================================
+ Hits         31634     31637        +3     
+ Misses        4824      4820        -4     
- Partials        47        48        +1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f37e3fe...7ba898e. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit d720136 into main Aug 12, 2025
51 checks passed
@philipphofmann philipphofmann deleted the test/non-fatal-event-debug-meta branch August 12, 2025 09:33
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration test for attaching debug meta for non fatal events

2 participants