Skip to content

Conversation

philipphofmann
Copy link
Member

Proposal for chaning flush for logs #5834.

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Proposal for flushing logs ([#5883](https://github.com/getsentry/sentry-cocoa/pull/5883))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against 39aceaa

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.359%. Comparing base (1752593) to head (39aceaa).
⚠️ Report is 18 commits behind head on enha/flush-logs-on-sdk-flush-and-close.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Swift/Tools/SentryLogBatcher.swift 0.000% 13 Missing ⚠️
Sources/Swift/Helper/SentrySDK.swift 0.000% 5 Missing ⚠️
Sources/Swift/Tools/SentryLogger.swift 0.000% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1752593) and HEAD (39aceaa). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (1752593) HEAD (39aceaa)
4 1
Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                              @@
##           enha/flush-logs-on-sdk-flush-and-close    #5883        +/-   ##
============================================================================
- Coverage                                  86.695%   8.359%   -78.336%     
============================================================================
  Files                                         423      391        -32     
  Lines                                       36536    34823      -1713     
  Branches                                    17282    13792      -3490     
============================================================================
- Hits                                        31675     2911     -28764     
- Misses                                       4816    31902     +27086     
+ Partials                                       45       10        -35     
Files with missing lines Coverage Δ
Sources/Swift/Tools/SentryLogger.swift 0.000% <0.000%> (-99.416%) ⬇️
Sources/Swift/Helper/SentrySDK.swift 1.923% <0.000%> (-85.427%) ⬇️
Sources/Swift/Tools/SentryLogBatcher.swift 0.000% <0.000%> (-98.980%) ⬇️

... and 405 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1752593...39aceaa. Read the comment docs.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1246.59 ms 1275.04 ms 28.45 ms
Size 23.75 KiB 920.02 KiB 896.27 KiB

Baseline results on branch: enha/flush-logs-on-sdk-flush-and-close

Startup times

Revision Plain With Sentry Diff
f58e80d 1222.61 ms 1252.23 ms 29.62 ms

App size

Revision Plain With Sentry Diff
f58e80d 23.75 KiB 920.20 KiB 896.46 KiB

@philipphofmann
Copy link
Member Author

@denrase already included the feedback in #5834, so we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant