-
-
Notifications
You must be signed in to change notification settings - Fork 366
Convert SentryAppState to Swift #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0fc875d
to
8d8396d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5872 +/- ##
========================================
Coverage ? 86.690%
========================================
Files ? 423
Lines ? 36621
Branches ? 17314
========================================
Hits ? 31747
Misses ? 4827
Partials ? 47
Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebc72be | 1221.24 ms | 1249.66 ms | 28.42 ms |
fc0757d | 1231.83 ms | 1248.98 ms | 17.15 ms |
f97a070 | 1218.88 ms | 1253.12 ms | 34.24 ms |
f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
1a34ddc | 1218.94 ms | 1251.86 ms | 32.92 ms |
ea5a59b | 1222.87 ms | 1253.47 ms | 30.60 ms |
83bb978 | 1238.33 ms | 1260.04 ms | 21.71 ms |
fdea6f5 | 1216.08 ms | 1241.82 ms | 25.73 ms |
ccf1278 | 1226.84 ms | 1248.51 ms | 21.67 ms |
9e0030e | 1222.78 ms | 1242.23 ms | 19.45 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ebc72be | 23.75 KiB | 908.22 KiB | 884.47 KiB |
fc0757d | 23.75 KiB | 850.73 KiB | 826.98 KiB |
f97a070 | 23.75 KiB | 858.68 KiB | 834.93 KiB |
f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
1a34ddc | 23.75 KiB | 919.88 KiB | 896.13 KiB |
ea5a59b | 23.75 KiB | 874.46 KiB | 850.71 KiB |
83bb978 | 23.75 KiB | 920.64 KiB | 896.89 KiB |
fdea6f5 | 23.75 KiB | 867.15 KiB | 843.40 KiB |
ccf1278 | 23.75 KiB | 877.15 KiB | 853.40 KiB |
9e0030e | 23.75 KiB | 893.72 KiB | 869.97 KiB |
Previous results on branch: sentryAppStateSwift
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
12be8c7 | 1207.08 ms | 1226.94 ms | 19.85 ms |
9cf0a30 | 1210.45 ms | 1238.35 ms | 27.90 ms |
b04dae0 | 1229.39 ms | 1259.47 ms | 30.08 ms |
e6d890b | 1210.31 ms | 1232.60 ms | 22.30 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
12be8c7 | 23.75 KiB | 924.51 KiB | 900.76 KiB |
9cf0a30 | 23.75 KiB | 924.86 KiB | 901.11 KiB |
b04dae0 | 23.75 KiB | 924.86 KiB | 901.11 KiB |
e6d890b | 23.75 KiB | 924.46 KiB | 900.71 KiB |
8d8396d
to
2331c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but there is one change in the deserialization you need to fix. I'll approve so you can proceed with the PR when fixed.
c04380a
to
9912b96
Compare
bb91d47
to
0ac089a
Compare
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
Migrate SentryAppState to Swift
#skip-changelog