Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 11, 2025

#skip-changelog

📜 Description

Bumps diffMax, as it's the only thing blocking #5668, and we discussed we should do this sepratley.

#5678

@denrase denrase marked this pull request as ready for review August 11, 2025 12:18
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.647%. Comparing base (f262e10) to head (e479af0).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5869       +/-   ##
=============================================
- Coverage   86.663%   86.647%   -0.017%     
=============================================
  Files          423       423               
  Lines        36405     36405               
  Branches     17230     17229        -1     
=============================================
- Hits         31550     31544        -6     
- Misses        4809      4814        +5     
- Partials        46        47        +1     

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f262e10...e479af0. Read the comment docs.

@philprime philprime changed the title Bump diff max chore: Increase maximum binary size diff in metrics check Aug 11, 2025
@philprime philprime changed the title chore: Increase maximum binary size diff in metrics check chore: Increase maximum binary diff size in metrics check Aug 11, 2025
@denrase denrase merged commit ae16459 into main Aug 11, 2025
58 of 61 checks passed
@denrase denrase deleted the chore/bump-diffMax branch August 11, 2025 12:55
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants