Skip to content

feat(V9): Make span read only in v9 #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2025
Merged

feat(V9): Make span read only in v9 #5866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG-v9.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Removes Decodable conformances from the public API of model classes (#5691)
Removes enableTracing property from SentryOptions (#5694)
Removes `integrations` property from `SentryOptions` (#5749)
Makes `SentryEventDecodable` internal (#5808)
The `span` property on `SentryScope` is now readonly (#5866)

### Fixes

Expand Down
4 changes: 4 additions & 0 deletions Sources/Sentry/Public/SentryScope.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ NS_SWIFT_NAME(Scope)
* Returns current Span or Transaction.
* @return current Span or Transaction or null if transaction has not been set.
*/
#if SDK_V9
@property (nullable, nonatomic, readonly, strong) id<SentrySpan> span;
#else
@property (nullable, nonatomic, strong) id<SentrySpan> span;
#endif // SDK_V9

/**
* The id of current session replay.
Expand Down
2 changes: 2 additions & 0 deletions Sources/Sentry/include/SentryScope+Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ NS_ASSUME_NONNULL_BEGIN

- (NSArray<SentryBreadcrumb *> *)breadcrumbs;

- (void)setSpan:(nullable id<SentrySpan>)span;

/**
* used to add values in event context.
*/
Expand Down
43 changes: 0 additions & 43 deletions sdk_api_V9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22320,49 +22320,6 @@
"Dynamic"
],
"accessorKind": "get"
},
{
"kind": "Accessor",
"name": "Set",
"printedName": "Set()",
"children": [
{
"kind": "TypeNameAlias",
"name": "Void",
"printedName": "Swift.Void",
"children": [
{
"kind": "TypeNominal",
"name": "Void",
"printedName": "()"
}
]
},
{
"kind": "TypeNominal",
"name": "Optional",
"printedName": "(any Sentry.Span)?",
"children": [
{
"kind": "TypeNominal",
"name": "Span",
"printedName": "any Sentry.Span",
"usr": "c:objc(pl)SentrySpan"
}
],
"usr": "s:Sq"
}
],
"declKind": "Accessor",
"usr": "c:objc(cs)SentryScope(im)setSpan:",
"moduleName": "Sentry",
"isOpen": true,
"objc_name": "setSpan:",
"declAttributes": [
"ObjC",
"Dynamic"
],
"accessorKind": "set"
}
]
},
Expand Down
Loading