Skip to content

Conversation

noahsmartin
Copy link
Contributor

This function wasn't doing anything because there was already an @property ... span defined above. Confirmed that it wasn't doing anything because the API stability check didn't trigger any changes by removing it

#skip-changelog

Copy link

codecov bot commented Aug 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.655%. Comparing base (7416ffc) to head (84199fe).
⚠️ Report is 25 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5865       +/-   ##
=============================================
+ Coverage   86.538%   86.655%   +0.117%     
=============================================
  Files          422       423        +1     
  Lines        36273     36405      +132     
  Branches     17130     17228       +98     
=============================================
+ Hits         31390     31547      +157     
+ Misses        4835      4810       -25     
  Partials        48        48               

see 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7416ffc...84199fe. Read the comment docs.

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.71 ms 1247.35 ms 24.63 ms
Size 23.75 KiB 913.63 KiB 889.89 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
64c2b2b 1233.96 ms 1260.20 ms 26.24 ms
9be5373 1215.92 ms 1239.44 ms 23.52 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms
cda95fc 1231.42 ms 1247.18 ms 15.77 ms
73c9712 1238.57 ms 1260.38 ms 21.80 ms
7b08a87 1220.14 ms 1246.10 ms 25.96 ms
cd9727b 1236.04 ms 1254.41 ms 18.37 ms
a3dfd57 1230.78 ms 1244.91 ms 14.14 ms
8ea5293 1242.70 ms 1262.25 ms 19.55 ms

App size

Revision Plain With Sentry Diff
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
64c2b2b 23.75 KiB 908.55 KiB 884.80 KiB
9be5373 23.75 KiB 866.50 KiB 842.75 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB
cda95fc 23.75 KiB 912.77 KiB 889.02 KiB
73c9712 23.75 KiB 908.01 KiB 884.26 KiB
7b08a87 23.74 KiB 913.70 KiB 889.95 KiB
cd9727b 23.75 KiB 879.25 KiB 855.51 KiB
a3dfd57 23.75 KiB 913.63 KiB 889.87 KiB
8ea5293 23.75 KiB 852.24 KiB 828.49 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, goog catch thanks.

@noahsmartin noahsmartin merged commit 1339919 into main Aug 11, 2025
134 checks passed
@noahsmartin noahsmartin deleted the removeUnnecessaryFunction branch August 11, 2025 14:02
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants