test: Use XCTestExpectation for concurrent modifications #5850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the dispatch group with an XCTestExpectation to get a failure message when the wait times out. To make this work this PR changes the method to an extension so it can call XCTestCase.wait. Furthermore, this PR reduces the timeout from 500s to 10s, because 500s is way to high and risks slowing down CI. Contributes to GH-5789
philipphofmann
requested review from
itaybre,
noahsmartin and
philprime
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5850 +/- ##
=============================================
+ Coverage 86.554% 86.655% +0.100%
=============================================
Files 422 423 +1
Lines 36273 36405 +132
Branches 17136 17229 +93
=============================================
+ Hits 31396 31547 +151
+ Misses 4833 4810 -23
- Partials 44 48 +4 see 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
philipphofmann
changed the title
philipphofmann
deleted the
test/xctestexpectation-concurrent-modifications
branch
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…)" This reverts commit a3dfd57.
philipsawyerdd
added a commit
to justin-doordash/sentry-cocoa
that referenced
this pull request
Sep 25, 2025
…)" This reverts commit a3dfd57.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the dispatch group with an XCTestExpectation to get a failure message when the wait times out. To make this work, this PR changes the method to an extension so it can call XCTestCase.wait. Furthermore, this PR reduces the timeout from 500s to 10s, because 500s is way too high and risks slowing down CI.
Contributes to GH-5789
#skip-changelog