Skip to content

Conversation

philipphofmann
Copy link
Member

Replace the dispatch group with an XCTestExpectation to get a failure message when the wait times out.

Contributes to GH-5789

#skip-changelog

Replace the dispatch group with an XCTestExpectation to get a failure
message when the wait times out.

Contributes to GH-5789
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.644%. Comparing base (d23a1b1) to head (a6c470b).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5848       +/-   ##
=============================================
+ Coverage   86.554%   86.644%   +0.089%     
=============================================
  Files          422       423        +1     
  Lines        36273     36405      +132     
  Branches     17136     17223       +87     
=============================================
+ Hits         31396     31543      +147     
+ Misses        4833      4815       -18     
- Partials        44        47        +3     

see 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23a1b1...a6c470b. Read the comment docs.

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit ca91f42 into main Aug 8, 2025
50 of 51 checks passed
@philipphofmann philipphofmann deleted the test/xctestexpectation-user branch August 8, 2025 08:08
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants