Skip to content

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Jul 23, 2025

Also from #5139, along with #5700, this fixes some incorrect assignments of kinds of versions to settings and infoplist entries.

#skip-changelog

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.540%. Comparing base (84094e8) to head (1f617dc).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5701       +/-   ##
=============================================
- Coverage   86.565%   86.540%   -0.026%     
=============================================
  Files          421       421               
  Lines        36049     36048        -1     
  Branches     15350     15348        -2     
=============================================
- Hits         31206     31196       -10     
- Misses        4805      4811        +6     
- Partials        38        41        +3     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84094e8...1f617dc. Read the comment docs.

Copy link
Contributor

github-actions bot commented Jul 23, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.67 ms 1260.61 ms 22.94 ms
Size 23.74 KiB 913.15 KiB 889.41 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e64d3d4 1241.90 ms 1260.10 ms 18.20 ms
9e0030e 1222.78 ms 1242.23 ms 19.45 ms
079bcc8 1217.88 ms 1234.88 ms 17.00 ms
9450cb4 1221.29 ms 1232.96 ms 11.67 ms
8ad303c 1220.02 ms 1231.79 ms 11.77 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms
162cd7f 1230.59 ms 1256.76 ms 26.16 ms
5c5648e 1234.44 ms 1253.79 ms 19.35 ms
c3fece5 1240.65 ms 1260.75 ms 20.10 ms
102cf89 1218.31 ms 1239.78 ms 21.47 ms

App size

Revision Plain With Sentry Diff
e64d3d4 23.75 KiB 855.37 KiB 831.62 KiB
9e0030e 23.75 KiB 893.72 KiB 869.97 KiB
079bcc8 23.74 KiB 874.07 KiB 850.33 KiB
9450cb4 23.75 KiB 908.55 KiB 884.80 KiB
8ad303c 23.75 KiB 879.24 KiB 855.49 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB
162cd7f 23.75 KiB 908.39 KiB 884.64 KiB
5c5648e 23.75 KiB 879.60 KiB 855.86 KiB
c3fece5 23.75 KiB 874.17 KiB 850.42 KiB
102cf89 23.74 KiB 891.02 KiB 867.27 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight
Copy link
Member Author

There is actually more work that would need to be done to avoid breaking the release flow, in VersionBump, so I'm not going to merge this as-is. I resolved the most recent conflicts, but the same kind will crop up again if another release is done.

@armcknight armcknight closed this Aug 5, 2025
@armcknight armcknight deleted the armcknight/fix/versioning branch August 5, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants