fix: Add support for globalThis (ES2020) when injecting debug IDs to JavaScript #2271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JakeShirley Thanks for the PR. However, it looks like this might be a duplicate of #2162. Could you please double check, and close your PR in favor of #2162 if that is the case? If your PR is different, please explain how it differs from the existing PR. |
|
@szokeasaurusrex that looks like it'd fit my use case just fine, I didn't see that PR! I'll close this now. That PR would be very useful to me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional global object to look for when injecting debug IDs into JS files.
We are using the QuickJS JavaScript engine which conforms to the ES2023 standard, and thus does not have
global,self, orwindow, but it does haveglobalThis.