docs: clearly state that system.internal-url-prefix shouldn't be changed
#3829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anged Happened today on Discord where a user changed internal-url-prefix and broke their instance. I think this should be stated clearer for new users and for non-native English speakers.
|
Ah, this explains why I had dejavu. I made the exact same PR a few years back. #3100 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3829 +/- ##
=======================================
Coverage 99.45% 99.45%
=======================================
Files 3 3
Lines 183 183
=======================================
Hits 182 182
Misses 1 1 ☔ View full report in Codecov by Sentry. |
BYK
requested changes
Jul 23, 2025
sentry/config.example.yml
Outdated
| # Most of the time, this should NOT be changed. It's used for communication | ||
| # between containers. `web` is the container's name, and `9000` is the | ||
| # default port exposed by the Sentry image. If you want to change the | ||
| # publicly exposed domain or port, you should probably change |
There was a problem hiding this comment.
Suggested change
| # publicly exposed domain or port, you should probably change | |
| # publicly exposed domain or port, you should change | |
| # `system.url-prefix` above instead | |
| # along with SENTRY_BIND in `.env` file. | |
| # Also see https://develop.sentry.dev/self-hosted/#productionalizing |
There was a problem hiding this comment.
Ughhh remind me a bit later
There was a problem hiding this comment.
I'm juggling so many things at work 😂
Co-authored-by: Burak Yigit Kaya <byk@sentry.io>
aminvakil
reviewed
Jul 24, 2025
Co-authored-by: Reinaldy Rafli <github@reinaldyrafli.com>
aminvakil
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened today on Discord where a user changed internal-url-prefix and broke their instance. I think this should be stated clearer for new users and for non-native English speakers.