-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(install): Adds support for podman(compose) #3673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DuncanConroy
wants to merge
64
commits into
getsentry:master
Choose a base branch
from
DuncanConroy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
d87c155
feat(install): Adds support for podman(compose), while maintaining co…
cd24311
Renames container-technology -> container-engine
64c9741
Adds feature flag to enable podman; fixes test runner
8034a6e
fix(install): platform detection for amd64
0fca38e
fix(install): Adds separate prox-args for podman build vs. podman-com…
d98e2fb
fix(install): Substitues docker compose --rmi for podman
27e524d
fix(install): handling of ps command for docker compose vs. podman-co…
d711b5b
fix(install): Susbstitutes docker compose --wait for podman
0e5e24e
fix(install): Substitues occurence of docker run with run
f89f0c2
fix(install): docker substitutions
7c886c9
fix(install): substitues docker volume create with correct syntax
8039e03
fix(install): remove dangling images under podman on compose down
00f4c81
fix(install): Replaces how images are pulled
b467a55
fix(install): Substitues up <service> --wait with start_service_and_…
b9bff98
fix(install): run podman-compose up with --force-recreate
8185732
fix(install): start_service_and_Wait_ready uses daemonized start
3bd844c
fix(install): multiple merge instrtuctions in docker-compose.yml
fc3d976
fix(install): Substitute --force-rm for podman
059f0c7
chore(install): simplify container-engine selection
ed1e604
chore(install): cleanups
abb4551
Update install/create-docker-volumes.sh
DuncanConroy b8a0206
Update install/turn-things-off.sh
DuncanConroy 5ae7db9
Update install/upgrade-clickhouse.sh
DuncanConroy e2d60ee
Update install/wrap-up.sh
DuncanConroy dd74c39
run tests with podman too
BYK cfa9157
fix sentry-admin script
BYK 9df8ab4
add missing renamed file
BYK b679f06
chore(install): Switch docker/podman if-else in install/update-docker…
400e4ea
fix import place
BYK 5abf5a7
chore(install): fixes from review
cb54be2
fix unbound variable error
BYK 6416fa6
remove incorrect pull_policy definitions
BYK 43f5431
lol
BYK 09f54a0
install podman-compose too?
BYK 257dc2d
sigh, try using brew to install
BYK 7259d27
shfmt
BYK 705a8b7
sigh...
BYK 8e6e116
podman install....
BYK 7d7f1c2
use ubuntu latest :facepalm:
BYK ffe08d8
bump podman version requirement one notch down
BYK 2544ec8
install podman-compose too
BYK 06e6e24
sigh...
BYK 8f0ba1a
moar swaps
BYK ab342b9
latest podman-compose
BYK 1973cb0
silence podman compose a bit
BYK a61a7a5
Merge branch 'master' into pr3673
BYK 69e671d
add --in-pod=false to dcr
BYK dc4c1db
lol, wrong line
BYK 485c264
try to fix force rm
BYK fe231a4
try no quotes at all
BYK ca40557
well, it should be --podman-build
BYK dbe912d
we don't need this as default is true
BYK a2792f7
--force-rm is no longer anyway
BYK 69d76b2
Merge branch 'master' into master
aldy505 9f9add5
Merge branch 'master' into master
aldy505 5ebfd90
explicitly set compose profiles to feature complete
aldy505 fba8afc
add COMPOSE_PROFILES into CI env vars
aldy505 1aaaadc
should be COMPOSE_PROFILES
aldy505 82944e0
specify `--profile` argument instead of environment variable, since i…
aldy505 33d7596
specify profile arg on dcr declaration
aldy505 091d949
Merge branch 'master' into master
aldy505 149a822
provide --profile flag on wrap-up
aldy505 fbd0181
ci: skip podman tests for now
aldy505 9c723b9
Merge branch 'master' into master
aldy505 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
echo "${_group}Creating volumes for persistent storage ..." | ||
|
||
echo "Created $(docker volume create --name=sentry-clickhouse)." | ||
echo "Created $(docker volume create --name=sentry-data)." | ||
echo "Created $(docker volume create --name=sentry-kafka)." | ||
echo "Created $(docker volume create --name=sentry-postgres)." | ||
echo "Created $(docker volume create --name=sentry-redis)." | ||
echo "Created $(docker volume create --name=sentry-symbolicator)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-clickhouse)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-data)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-kafka)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-postgres)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-redis)." | ||
echo "Created $($CONTAINER_TECHNOLOGY volume create --name=sentry-symbolicator)." | ||
|
||
echo "${_endgroup}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
echo "${_group}Detecting container technology ..." | ||
|
||
export CONTAINER_TECHNOLOGY="" | ||
|
||
if command -v podman &> /dev/null; then | ||
DuncanConroy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
CONTAINER_TECHNOLOGY="podman" | ||
elif command -v docker &> /dev/null; then | ||
CONTAINER_TECHNOLOGY="docker" | ||
else | ||
echo "FAIL: Neither podman nor docker is installed on the system." | ||
exit 1 | ||
fi | ||
echo "Detected container technology: $CONTAINER_TECHNOLOGY" | ||
echo "${_endgroup}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
echo "${_group}Fetching and updating Docker images ..." | ||
echo "${_group}Fetching and updating $CONTAINER_TECHNOLOGY images ..." | ||
|
||
# We tag locally built images with a '-self-hosted-local' suffix. `docker | ||
# compose pull` tries to pull these too and shows a 404 error on the console | ||
# which is confusing and unnecessary. To overcome this, we add the | ||
# stderr>stdout redirection below and pass it through grep, ignoring all lines | ||
# having this '-onpremise-local' suffix. | ||
|
||
$dc pull -q --ignore-pull-failures 2>&1 | grep -v -- -self-hosted-local || true | ||
$dc pull --ignore-pull-failures 2>&1 | grep -v -- -self-hosted-local || true | ||
|
||
# We may not have the set image on the repo (local images) so allow fails | ||
docker pull ${SENTRY_IMAGE} || true | ||
$CONTAINER_TECHNOLOGY pull ${SENTRY_IMAGE} || true | ||
|
||
echo "${_endgroup}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.