Skip to content

feat: Enable getting/setting debug ID on DecodedMap #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 100 additions & 2 deletions src/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,24 @@ impl DecodedMap {
}
}
}

/// Returns the debug ID of the sourcemap, if it exists.
pub fn debug_id(&self) -> Option<DebugId> {
match self {
DecodedMap::Regular(sm) => sm.get_debug_id(),
DecodedMap::Index(smi) => smi.debug_id(),
DecodedMap::Hermes(smh) => smh.get_debug_id(),
}
}

/// Sets the debug ID of the sourcemap.
pub fn set_debug_id(&mut self, debug_id: Option<DebugId>) {
match self {
DecodedMap::Regular(sm) => sm.set_debug_id(debug_id),
DecodedMap::Index(smi) => smi.set_debug_id(debug_id),
DecodedMap::Hermes(smh) => smh.set_debug_id(debug_id),
}
}
}

/// Represents a raw token
Expand Down Expand Up @@ -1110,9 +1128,13 @@ impl SourceMapIndex {
self.debug_id
}

fn set_debug_id(&mut self, debug_id: Option<DebugId>) {
self.debug_id = debug_id;
}

/// Adds the given debug id to the sourcemap index.
pub(crate) fn with_debug_id(mut self, debug_id: Option<DebugId>) -> Self {
self.debug_id = debug_id;
self.set_debug_id(debug_id);
self
}

Expand Down Expand Up @@ -1320,7 +1342,9 @@ impl SourceMapSection {

#[cfg(test)]
mod tests {
use super::{RewriteOptions, SourceMap, SourceMapIndex};
use std::collections::BTreeSet;

use super::{DecodedMap, RewriteOptions, SourceMap, SourceMapIndex};
use debugid::DebugId;

#[test]
Expand Down Expand Up @@ -1449,6 +1473,80 @@ mod tests {
);
}

#[test]
fn test_decoded_map_regular_debug_id() {
const DEBUG_ID: &str = "0123456789abcdef0123456789abcdef";

let mut decoded_map = DecodedMap::Regular(SourceMap {
file: None,
tokens: vec![],
names: vec![],
source_root: None,
sources: vec![],
sources_prefixed: None,
sources_content: vec![],
ignore_list: BTreeSet::new(),
debug_id: None,
});

assert!(decoded_map.debug_id().is_none());

decoded_map.set_debug_id(Some(DEBUG_ID.parse().expect("valid debug id")));

assert_eq!(
decoded_map,
DecodedMap::Regular(SourceMap {
file: None,
tokens: vec![],
names: vec![],
source_root: None,
sources: vec![],
sources_prefixed: None,
sources_content: vec![],
ignore_list: BTreeSet::new(),
debug_id: Some(DEBUG_ID.parse().expect("valid debug id")),
})
);

assert_eq!(
decoded_map.debug_id(),
Some(DEBUG_ID.parse().expect("valid debug id"))
);
}

#[test]
fn test_decoded_map_index_debug_id() {
const DEBUG_ID: &str = "0123456789abcdef0123456789abcdef";

let mut decoded_map = DecodedMap::Index(SourceMapIndex {
file: None,
sections: vec![],
x_facebook_offsets: None,
x_metro_module_paths: None,
debug_id: None,
});

assert!(decoded_map.debug_id().is_none());

decoded_map.set_debug_id(Some(DEBUG_ID.parse().expect("valid debug id")));

assert_eq!(
decoded_map,
DecodedMap::Index(SourceMapIndex {
file: None,
sections: vec![],
x_facebook_offsets: None,
x_metro_module_paths: None,
debug_id: Some(DEBUG_ID.parse().expect("valid debug id")),
})
);

assert_eq!(
decoded_map.debug_id(),
Some(DEBUG_ID.parse().expect("valid debug id"))
);
}

mod prop {
//! This module exists to test the following property:
//!
Expand Down