fix: Avoid global.json when running all dotnet commands

[Flash0ver]

Summary

The Sentry .NET SDK uses a global.json file to pin a specific version of the .NET SDK and .NET Workloads to ensure reproducible builds.
When pushing the Sentry NuGet packages and Symbol packages, we can use any version of the .NET SDK,
as long as we ensure that the actual dotnet build, dotnet test, and creating the packages via dotnet pack run with the pinned version of the .NET SDK.

In a previous PR, see #601,
we applied spawnOptions to the invocation of dotnet nuget push via spawnProcess,
with which we set the Working Directory outside of the sentry-dotnet repository,
so that the global.json does not get picked up / enforced.

However,
we forgot to apply the same spawnOptions to the other invocations of dotnet commands.

This manifests in failure when invoking dotnet --version:

...
[info] [[target/nuget]] .NET Version:
Error:  Process "dotnet" errored with code 145
...
dotnet: 8.0.412 [/usr/share/dotnet/sdk]
dotnet: 9.0.303 [/usr/share/dotnet/sdk]
...
dotnet: Requested SDK version: 9.0.301
dotnet: global.json file: global.json
...

Publish using Craft

[info] [[target/nuget]] .NET Version:
Error:  Process "dotnet" errored with code 145

STDOUT: dotnet: 8.0.412 [/usr/share/dotnet/sdk]
dotnet: 9.0.303 [/usr/share/dotnet/sdk]
dotnet: 


STDERR:dotnet: The command could not be loaded, possibly because:
dotnet:   * You intended to execute a .NET application:
dotnet:       The application '--version' does not exist.
dotnet:   * You intended to execute a .NET SDK command:
dotnet:       A compatible .NET SDK was not found.
dotnet: 
dotnet: Requested SDK version: 9.0.301
dotnet: global.json file: /github/workspace/__repo__/global.json
dotnet: 
dotnet: Installed SDKs:
dotnet: 
dotnet: Install the [9.0.301] .NET SDK or update [/github/workspace/__repo__/global.json] to match an installed SDK.
dotnet: 
dotnet: Learn about SDK resolution:
dotnet: https://aka.ms/dotnet/sdk-not-found
dotnet: 

  
  STDOUT: dotnet: 8.0.412 [/usr/share/dotnet/sdk]
  dotnet: 9.0.303 [/usr/share/dotnet/sdk]
  dotnet:
  
  
  STDERR:dotnet: The command could not be loaded, possibly because:
  dotnet:   * You intended to execute a .NET application:
  dotnet:       The application '--version' does not exist.
  dotnet:   * You intended to execute a .NET SDK command:
  dotnet:       A compatible .NET SDK was not found.
  dotnet:
  dotnet: Requested SDK version: 9.0.301
  dotnet: global.json file: global.json
  dotnet:
  dotnet: Installed SDKs:
  dotnet:
  dotnet: Install the [9.0.301] .NET SDK or update [global.json] to match an installed SDK.
  dotnet:
  dotnet: Learn about SDK resolution:
  dotnet: https://aka.ms/dotnet/sdk-not-found
  dotnet:
  
  at Bqe (/usr/local/bin/craft:357:15452)
  at p (/usr/local/bin/craft:361:467)
  at ChildProcess.<anonymous> (/usr/local/bin/craft:361:761)
  at ChildProcess.emit (node:events:518:28)
  at ChildProcess.emit (node:domain:489:12)
  at ChildProcess._handle.onexit (node:internal/child_process:293:12)

Changes

Applying the previously added spawnOptions to the invocations of all dotnet commands,
not just dotnet nuget push.

See also

• Temporarily disable global.json when pushing NuGet packages #598
• fix: Avoid global.json when running dotnet push #601

[bruno-garcia]

LGTM! Thanks Stefan.

[Flash0ver]

question: Is this the right way to do it?

Alternative:
As private readonly field on class NugetTarget.

[asottile-sentry]

[bruno-garcia]

Thanks @asottile-sentry