feat(maven): add new config to process klib distributions differently from root and apple #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
commented
Jul 21, 2025
| kmp: | ||
| rootDistDirRegex: /sentry-kotlin-multiplatform-[0-9]+.*$/ | ||
| appleDistDirRegex: /sentry-kotlin-multiplatform-(macos|ios|tvos|watchos).*/ | ||
| klibDistDirRegex: /sentry-kotlin-multiplatform-(js|wasm-js).*/ |
There was a problem hiding this comment.
I'm also open for another name for this config
|
@romtsn I don't really have an opinion here unless it changes a fundamental Craft principle like not publishing the same version twice etc. I don't have an opinion specifically about Maven. |
|
👍 , no changes here that alter craft behaviours, only adding support for publishing new targets on maven with KMP I'll merge this then |
BYK
pushed a commit
that referenced
this pull request
Oct 1, 2025
… from root and apple (#612) * Add support for single klib * Update tests * Update README * Revert README * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For KMP we are going to publish new targets:
js,wasm-js,linux,mingwand all the artifacts to publish are currently not compatible with the KMP implementation in craft -> they would be processed incorrectly with the current implementationAll these distributions have the same structure so we can add a new config that targets these. They all contain 5 files: 1 -source.jar, 1 -javadoc.jar, 1 .klib, 1 .module and 1 pom file.