Skip to content

fix(aws): make reading/writing of aws manifest consistent with other packages #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jun 11, 2025

see the corresponding implementation here for all other packages:

JSON.parse(
await fsPromises.readFile(packageManifestPath, { encoding: 'utf-8' })
) || {},

const manifestString = JSON.stringify(updatedManifest, undefined, 2) + '\n';

mainly the newline at the end was missing which was causing the aws endpoint failures I think.

@sl0thentr0py sl0thentr0py requested a review from cleptric June 11, 2025 12:18
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be extracted out as a helper to help with consistency?

@sl0thentr0py
Copy link
Member Author

sl0thentr0py commented Jun 11, 2025

the helpers already exist in utils as linked above.. I don't know why whoever wrote the aws stuff didn't use them.
Don't really have time for a refactor here right now, sorry!

@sl0thentr0py sl0thentr0py merged commit 45c5dd1 into master Jun 12, 2025
13 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/make-aws-stringify-consistent branch June 12, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants