Move script dependencies to top-level package.json

[alxndrsn]

Closes #430

Maybe?

[changeset-bot]

⚠️ No Changeset found

Latest commit: e56fd19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[latin-panda]

The intention is to keep the root's package.json file minimal. In my opinion, it's okay to keep globby and mustache dependencies here because they are not used anywhere else, and these scripts aren't vital for WF functioning.

What do you think?

[alxndrsn]

these scripts aren't vital for WF functioning

I think that's the purpose of devDependencies.

What are the benefits of a minimal root package.json?

If these dependencies are kept in scripts/package.json, would you be open to a PR to add scripts/yarn.lock?

I think additionally, scripts/package.json would then also replicate some of the stuff in /package.json which standardises tools, specifically:

{
  "engines": {
    "node": "^18.20.5 || ^20.18.1 || ^22.12.0",
    "yarn": "1.22.22"
  },
  "volta": {
    "node": "22.12.0",
    "yarn": "1.22.22"
  },
  "packageManager": "yarn@1.22.22"
}

[alxndrsn]

Alternatively, maybe scripts/package.json can be removed completely.

[latin-panda]

I like the idea of adding engines, volta, and a lock file to /scripts, which will ensure consistency and maintain isolation and separation from the source. I can prepare a PR with those changes :)

[latin-panda]

We discussed this during the team meeting and decided to keep the /script with its dependencies. We have added the lock file and node engine definition to the package.json to align with the root. Addressed here. cc: @lognaturel