Substantially narrower design for adding media to label interfaces #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on this yesterday but didn't get it quite there before an early EOD, but I wanted to make it visible this morning while I have the opportunity. I can write this up, and we could decide on the best approach to resolving it as a design decision and/or artifact. Opening as draft for now.
This is an alternative approach, incrementally working towards designs in #373. This design would be additive, leaving much of the work done in the previous design to be handled as later steps in a sequence. A couple of notes are added in JSDoc as breadcrumbs about how this design could evolve toward that one. Another note is added, as a hint to implementation, regarding how the current
jr:itextbehavior could be preserved while media support is added, leaving #121 to be addressed in a followup rather than as two-birds-one-stone.Edit to add: this will fail CI as-is because it adds aspects to an existing client interface but doesn't yet implement them. I could also implement minimal placeholders for the added properties to unblock CI, if the design-as-PR is considered valuable as an artifact.