-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: allow training multiple capture actions in one recording session #562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
7fe982a
feat: allow multiple capture action execution
RohitR311 c6266fd
feat: emit action type
RohitR311 cd4820f
feat: serialize data by action type
RohitR311 bd5087e
feat: run and abort categorize data by action type
RohitR311 35e7778
feat: schedule categorize data by action type
RohitR311 00ef3ba
feat: record api categorize data by action type
RohitR311 6243563
feat: track browser actions state
RohitR311 6376fd6
feat: reset interpret log list screenshot
RohitR311 b5c5ed7
feat: check action exists in workflow
RohitR311 42b56d7
feat: emit recording editor actions by type
RohitR311 82d6f70
feat: revamp output preview log ui
RohitR311 a00e69e
feat: change scrape schema merge logic
RohitR311 a7771cf
feat: memoize handle url change
RohitR311 f975862
feat: revamp run content ui
RohitR311 8d06146
feat: add translations for run content
RohitR311 4ed3160
feat: emit socket events for stopping
RohitR311 2ffbdc7
feat: revamp gsheet integration multiple actions
RohitR311 109afff
feat: revamp airtable integration multiple actions
RohitR311 882b25c
feat: correct key used when checking unconfirmed list fields
RohitR311 01ab958
feat: replace banned Function type with an explicit signature
RohitR311 c7e3a66
feat: maxlen 0 if field not exist
RohitR311 f1d0cbd
feat: rm other actions logic
RohitR311 b4e3ccd
Merge branch 'develop' into all-record
amhsirak f1c1488
fix: lint
amhsirak 0c5e98c
fix: lint
amhsirak d0f284c
chore: -rm unused imports
amhsirak f65dda0
feat: -rm download all json
amhsirak 302ec00
feat: -rm horizontal view
amhsirak e5f63be
feat: -rm vertical view
amhsirak 9eeb367
feat: -rm box
amhsirak 458392d
feat: -rm horizontal view from screenshots
amhsirak db890e0
feat: -rm vertical view from screenshots
amhsirak e6a7fdf
feat: -rm box
amhsirak 2b04634
feat: -rm unused icons
amhsirak c202a50
feat: -rm icons for capture text and list
amhsirak cf5be61
feat: -rm icons
amhsirak 47ed5ce
feat: -rm icons
amhsirak 7c7116a
feat: -rm captured data
amhsirak 1f06bcd
feat: -rm captured screenshots
amhsirak 392a5fd
feat: rm workflow in progress logic
RohitR311 624d7fc
Merge branch 'all-record' of https://github.com/getmaxun/maxun into a…
RohitR311 9bc9815
feat: -rm chips
amhsirak 94fecc1
feat: -rm download all json
amhsirak 9c57824
feat: -rm download all json
amhsirak decf14a
fix: cleanup
amhsirak b72d0dc
chore: remove unused import
amhsirak 43b7a7d
feat: rm view mode logic
RohitR311 02a150d
feat: paginate capture screenshots
RohitR311 b83fcb2
feat: rm left space
RohitR311 db25627
feat: change translations
RohitR311 5cd756c
feat: rm card componenent
RohitR311 3b618d8
feat: rm screenshot items chip
RohitR311 6419d31
feat: buttons ui change, rm render expand
RohitR311 daa9779
feat: rm unnecessray imports
RohitR311 eed8ff3
Merge pull request #574 from getmaxun/all-record-ui
RohitR311 7b6de7d
feat: fix download ss logic
RohitR311 f5df4c9
feat: rm other page and data
RohitR311 e09e794
feat: show tabs only if multiple actions
RohitR311 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify that the UI correctly handles action state throughout the capture flow
These changes support the action state management in the UI layer. Let's ensure that the
setActionType
callback integrates correctly with the UI's action lifecycle management.Also applies to: 381-383, 391-393, 421-423, 432-434, 478-480, 493-495, 507-509, 520-522, 532-534, 566-568
🏁 Script executed:
Length of output: 138
🏁 Script executed:
Length of output: 2760
Ensure the UI wires up the new
setActionType
callbackWe found calls to
debugChannel.setActionType
inmaxun-core/src/interpret.ts
but no corresponding handling in the UI. The recorder panel only subscribes tostartAction
/finishAction
, so your new action-type updates won’t propagate unless you explicitly pass and handlesetActionType
in your React components.Locations to update:
• Include
setActionType
in the debug channel props alongsidestartAction
/finishAction
.• Add logic (e.g., a state setter or effect) to respond to
setActionType(type)
calls and update the UI accordingly.Without these changes, the UI won’t reflect the action‐type changes emitted by
interpret.ts
.🧰 Tools
🪛 Biome (1.9.4)
[error] 48-48: Don't use 'Function' as a type.
Prefer explicitly define the function shape. This type accepts any function-like value, which can be a common source of bugs.
(lint/complexity/noBannedTypes)