Skip to content

Fix #348 topic display name too long #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix #348 topic display name too long #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13ea7a7
fix: #348 topic display name too long
Jul 26, 2023
8c42e97
fix: test
Jul 26, 2023
f2f787d
chore: change requests to simplify shortening
Aug 2, 2023
8c8b7a2
chore: updated message for CR's
Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/constructs/aws/Queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,9 +232,12 @@ export class Queue extends AwsConstruct {

const alarmEmail = configuration.alarm;
if (alarmEmail !== undefined) {
// generate the display name, AWS restriction is 100 chars
const displayName = `[Alert][${id}] failed jobs in the DLQ.`.substring(0, 100);

const alarmTopic = new Topic(this, "AlarmTopic", {
topicName: `${this.provider.stackName}-${id}-dlq-alarm-topic`,
displayName: `[Alert][${id}] There are failed jobs in the dead letter queue.`,
displayName,
});
new Subscription(this, "AlarmTopicSubscription", {
topic: alarmTopic,
Expand Down
2 changes: 1 addition & 1 deletion test/unit/queues.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ describe("queues", () => {
Properties: {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
TopicName: expect.stringMatching(/test-queues-\w+-dev-emails-dlq-alarm-topic/),
DisplayName: "[Alert][emails] There are failed jobs in the dead letter queue.",
DisplayName: "[Alert][emails] failed jobs in the DLQ.",
},
});
expect(cfTemplate.Resources[computeLogicalId("emails", "AlarmTopicSubscription")]).toMatchObject({
Expand Down