Skip to content

fix: fix out of bounds access on stream start_capture #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 13, 2025
Merged

fix: fix out of bounds access on stream start_capture #95

merged 10 commits into from
Sep 13, 2025

Conversation

iparaskev
Copy link
Contributor

Closes #94.

Also makes a few more changes, in particular:

  • Adds a spiner after the a screen has been selected for sharing.
  • Makes the feedback tab more engaging.
  • Makes the error messages more informative when the app needs to be restarted.
  • Updates the mock data to contain the unsubscribe_id.

@iparaskev
improvement(frontend): add loading spinner when selecting content
5e967c9
@iparaskev
chore(backend): update mock data
f2b864f
@iparaskev
fix(core): fix out of bounds access on stream restart
c0d5838 
When the capturer fails with a permanent error from the OS, we
are restarting it and during the restart we were accessing the first
available source without checking if there are no sources. This is
wrong because if the captuer is in an error state it could return
0 available sources.

Stream::start_capture has been modified now to return an error.
@iparaskev
improvement: show better error messages when core has stopped
f2cb592
@iparaskev
chore: make form more engaging
a8cff0d
@iparaskev
fix: add spiner state var
54aa2cb
@iparaskev iparaskev requested a review from konsalex as a code owner September 13, 2025 13:07
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2025 •
edited
Loading

✅ Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit b8e17e7
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/68c592e68bf750000840615a
😎 Deploy Preview https://deploy-preview-95--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@iparaskev iparaskev mentioned this pull request Sep 13, 2025
Closed
konsalex
konsalex previously approved these changes Sep 13, 2025
View reviewed changes
@iparaskev iparaskev merged commit 99a160f into main Sep 13, 2025
20 checks passed
@iparaskev iparaskev deleted the fix-94 branch September 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@konsalex konsalex konsalex left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: hopp_core crashed during call

2 participants

@iparaskev @konsalex